-
Notifications
You must be signed in to change notification settings - Fork 0
feat(eval): add bounded host experiment recorder #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b97f270
chore(eval): remove legacy observation surfaces
jgoneit 68a3396
feat(eval): add bounded experiment recorder
jgoneit a66dfbe
test(eval): cover recorder safety boundaries
jgoneit ab23436
ci(eval): run recorder checks
jgoneit 6618f03
docs(eval): define twenty task experiment
jgoneit 90d13e0
ci(eval): enforce LF for Go sources
jgoneit 08e0f3e
fix(store): validate Windows security descriptors
jgoneit 278d407
test(store): cover Windows private root semantics
jgoneit d18fe81
fix(store): anchor journal existence checks
jgoneit ed75e17
test(store): cover moved root journal reads
jgoneit 60698f9
fix(state): resolve platform user home
jgoneit f126027
test(state): cover platform home fallback
jgoneit e6d9726
docs(eval): document Windows journal fallback
jgoneit 6c05f97
chore(config): quarantine legacy private data
jgoneit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| *.go text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| name: verify | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| name: test (${{ matrix.os }}) | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 15 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.25.x" | ||
| cache: true | ||
| - name: Check formatting | ||
| shell: bash | ||
| run: test -z "$(gofmt -l .)" | ||
| - name: Vet | ||
| run: go vet ./... | ||
| - name: Test | ||
| run: go test ./... | ||
| - name: Build evalctl | ||
| run: go build ./cmd/evalctl | ||
|
|
||
| race: | ||
| name: race | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.25.x" | ||
| cache: true | ||
| - run: go test -race ./... | ||
|
|
||
| surface: | ||
| name: clean-slate surface | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Reject removed product and compatibility surfaces | ||
| shell: bash | ||
| run: | | ||
| test ! -e .codex-plugin | ||
| test ! -e skills | ||
| test ! -e fixtures | ||
| test ! -e templates | ||
| test ! -e toolkit-module.json | ||
| test ! -e requirements-dev.txt | ||
| test ! -e scripts/verify.sh | ||
| test ! -e internal/analyze | ||
| test "$(find schemas -type f | wc -l | tr -d ' ')" = "1" | ||
| test -f schemas/experiment-v1.schema.json | ||
| ! rg -n 'eval-observation|observations\.jsonl|task_id|supersedes|observe-draft-v2' cmd internal schemas go.mod | ||
| ! rg -n 'runValidate|runSummarize|runCompare|case "(validate|summarize|compare)"' cmd internal/cli --glob '!**/*_test.go' | ||
| ! rg -n '/Users/[[:alnum:]_.-]+/' . --hidden --glob '!.git/**' | ||
| - name: Verify legacy privacy quarantine | ||
| shell: bash | ||
| run: | | ||
| mkdir -p reports/private | ||
| printf '%s\n' canary > observations.jsonl | ||
| printf '%s\n' canary > reports/private/canary.jsonl | ||
| test -z "$(git ls-files -- observations.jsonl reports/private)" | ||
| git check-ignore --quiet observations.jsonl | ||
| git check-ignore --quiet reports/private/canary.jsonl | ||
| test -z "$(git add --dry-run -A)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.