Conversation
kinonn
referenced
this pull request
in kinonn/Split-Flap-Display-Multi
Sep 7, 2026
…33 (#30) - #29 (P1): P0 completes only on a verified capture of the tagged index frame passing the deterministic P0 guards (crop count + distinct means); tag alone merely arms registration. - #30 (P1): remote (scope 2..6) and display-kind persists require a prior photo cycle; local preview-before-persist gate unchanged. - #31 (P2): hold is harness-owned — run() engages at start, _done() releases; tool_hold(true) allowed, tool_hold(false) refused. - #32 (P2): finish(converged) requires P0, a non-empty template bank, classical acceptance, plus an image-sanity capture (glyph signal on every module) so a blind camera cannot converge by omission. - #33 (P2): captures feed identity/bank only when claimed expected exactly matches the shown frame; mismatches return photo+scores with a warning and feed nothing. - #34 already fixed on this branch by #29 (alloc_run_dir in both servers); verified, no change needed. Tests: 8 new regression tests in app/tests/test_agent.py; 16/16 stub-harness runtime checks pass against the real Agent+Calibrator (no numpy/cv2 in this env, so full pytest left to CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My display would stop responding to queue messages sometimes. I added a regular publish the availability queue so I could tell it was still online. Also added a re-connect to the loop if it detects MQTT isn't available.