Conversation
There was a problem hiding this comment.
Reviewed the reverse-sync export, controller scheduling, runner admission/leases, and task cleanup paths.
Findings:
- Manual Pod creation failures leave credential-bearing Secrets behind.
- The enabled runner image has no production adapter bindings, so every admitted reverse run fails before delivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JITSU-227. Executable Node runner and syncctl/CronJob integration, following the merged core-mirror PR #1519. Stacked on the still-open persistence PR #1516; merge that first.
Boundaries
Validation
-vet=offbecause unchangedfmt.Errorf(stderr.String())in existing job_runner.go fails the current Go vet check.No production databases, Kubernetes clusters, advertising APIs or release/deployment workflows were invoked. Next slice: first verified Google Ads adapter, followed by complete Reverse sync UI and end-to-end rollout.