docs(rfc): correct the stale presence-detection note for rebase_config - #608
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
martinsifra
force-pushed
the
ms/dmd-1833
branch
from
August 18, 2026 22:50
0b88991 to
25a80a5
Compare
The Testing section still described the pre-#606 behaviour -- `rebase_config` sending `is_disabled=False` but omitting `is_disabled=None`. `is_disabled` is `bool` now, so `None` is not expressible at all. My miss in #606: D1 and the signature table were updated, this bullet was not. It talks about the parameters by describing their behaviour rather than naming `rebase_config`'s signature, so grepping for the symbol did not surface it.
padak
force-pushed
the
padak/dmd-1833-rfc-presence-note
branch
from
August 18, 2026 23:03
163bc6a to
9839b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One stale bullet in the RFC's Testing section, spotted while re-reviewing #556 for approval. Targets
ms/dmd-1833.It still described the pre-#606 behaviour:
is_disabledisboolsince #606, soNonecannot be passed at all. The bullet now describes what the method actually does — always sends the replaced body, omits onlydescription=Noneand an unsetchange_description.My miss in #606: I updated D1 and the signature table but not this bullet. It refers to the parameters by describing their behaviour rather than naming the signature, so grepping for
rebase_configdid not surface it — it took a grep foris_disabled=None.Docs only, no code touched.
make checkgreen (5774 passed,tyclean, all gates OK). Note that no CI will run here either —ci.ymlis scoped topull_request: branches: [main].