Skip to content

PRDCT-685: Dependabot bumps — September safe set (no framework majors) - #1130

Open
Iamfle4ka wants to merge 1 commit into
mainfrom
chore/dependabot-sept-safe-bumps
Open

Iamfle4ka wants to merge 1 commit into
mainfrom
chore/dependabot-sept-safe-bumps

Conversation

@Iamfle4ka

Copy link
Copy Markdown
Collaborator

Jira issue(s): PRDCT-685

Rolls the three routine September Dependabot PRs into one lockfile pass. Keeping them apart means four reviews of the same package-lock.json, and #1125 / #1126 bump the same package (@vercel/node), so they would conflict with each other.

Same split as August: safe set here, framework major separate (#1066 / #1067).

Package From To Source PR How
svgo 4.0.2 4.1.0 #1121 transitive, lockfile only
smol-toml 1.5.2 1.7.1 #1125 transitive, lockfile only
@vercel/node ^5.8.4 ^5.10.2 #1125, #1126 direct
js-yaml ^4.2.0 ^4.3.2 #1126 direct

Method

package.json bumped by hand for the two direct deps, lockfile regenerated with npm install, then npm audit fixnever --force, which wants @vercel/node@4.0.0, a breaking downgrade. None of the bots' lock diffs were cherry-picked.

git diff package.json is exactly the two lines above. Verified in the lockfile that the majors did not move: astro 6.4.8, sharp 0.33.5, @astrojs/starlight 0.38.5, @astrojs/mdx 5.0.6.

Result

npm audit: 18 advisories (1 critical / 11 high / 5 moderate / 1 low) → 11 (1 critical / 4 high / 5 moderate / 1 low).

Seven highs closed: svgo, smol-toml, js-yaml, minimatch, nanoid, @vercel/build-utils, @vercel/python-analysis.

What did not close, stated plainly: the @vercel/nodeundici / path-to-regexp chain survives the bump to 5.10.2. npm's only offered fix for it is the downgrade to 4.0.0, so it stays open — same conclusion #1066 reached in August. The rest (astro, sharp, starlight, mdx, astro-expressive-code) needs the major upgrade.

npm run check:cli passes (0 findings) and npm run build is clean, 363 pages.

Out of scope

Worth flagging

The single critical is on astro itself: vulnerable range <=7.2.7, fixed in 7.3.2. #1067 currently targets ^7.1.6, so it no longer closes this critical — its target needs raising to ≥7.3.2 (and sharp to 0.35.4) when it comes back into play.

🤖 Generated with Claude Code

Combines the three routine September Dependabot PRs into one lockfile
pass: svgo (#1121), smol-toml + @vercel/node (#1125), js-yaml + the same
@vercel/node (#1126). The last two bump the same package, so they would
have conflicted with each other.

package.json is bumped by hand for the two direct deps and the lockfile
regenerated, rather than cherry-picking the bots' lock diffs. `npm audit
fix` without --force: --force wants @vercel/node@4.0.0, a breaking
downgrade.

npm audit 18 -> 11 advisories; 11 high -> 4. astro, sharp, starlight and
mdx stay on their current majors — that upgrade is #1067.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
connection-docs Ready Ready Preview Sep 15, 2026 10:48am UTC

Request Review

@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown

PRDCT-685

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 4/5) · profile connection-docs

Dependency bump touching package.json and package-lock.json — escalating to a human per policy.

Impact flags: possible rollback re-introduction — see Check Run summary.

Suggested reviewers: @keboola/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants