Conversation
Combines the three routine September Dependabot PRs into one lockfile pass: svgo (#1121), smol-toml + @vercel/node (#1125), js-yaml + the same @vercel/node (#1126). The last two bump the same package, so they would have conflicted with each other. package.json is bumped by hand for the two direct deps and the lockfile regenerated, rather than cherry-picking the bots' lock diffs. `npm audit fix` without --force: --force wants @vercel/node@4.0.0, a breaking downgrade. npm audit 18 -> 11 advisories; 11 high -> 4. astro, sharp, starlight and mdx stay on their current majors — that upgrade is #1067. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 4/5) · profile connection-docs
Dependency bump touching package.json and package-lock.json — escalating to a human per policy.
Impact flags: possible rollback re-introduction — see Check Run summary.
Suggested reviewers: @keboola/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue(s): PRDCT-685
Rolls the three routine September Dependabot PRs into one lockfile pass. Keeping them apart means four reviews of the same
package-lock.json, and #1125 / #1126 bump the same package (@vercel/node), so they would conflict with each other.Same split as August: safe set here, framework major separate (#1066 / #1067).
svgosmol-toml@vercel/nodejs-yamlMethod
package.jsonbumped by hand for the two direct deps, lockfile regenerated withnpm install, thennpm audit fix— never--force, which wants@vercel/node@4.0.0, a breaking downgrade. None of the bots' lock diffs were cherry-picked.git diff package.jsonis exactly the two lines above. Verified in the lockfile that the majors did not move:astro6.4.8,sharp0.33.5,@astrojs/starlight0.38.5,@astrojs/mdx5.0.6.Result
npm audit: 18 advisories (1 critical / 11 high / 5 moderate / 1 low) → 11 (1 critical / 4 high / 5 moderate / 1 low).Seven highs closed:
svgo,smol-toml,js-yaml,minimatch,nanoid,@vercel/build-utils,@vercel/python-analysis.What did not close, stated plainly: the
@vercel/node→undici/path-to-regexpchain survives the bump to 5.10.2. npm's only offered fix for it is the downgrade to 4.0.0, so it stays open — same conclusion #1066 reached in August. The rest (astro,sharp,starlight,mdx,astro-expressive-code) needs the major upgrade.npm run check:clipasses (0 findings) andnpm run buildis clean, 363 pages.Out of scope
astro.config.mjsandsrc/pages/404.astrochanges. Left open, nothing closed.Worth flagging
The single critical is on
astroitself: vulnerable range<=7.2.7, fixed in7.3.2. #1067 currently targets^7.1.6, so it no longer closes this critical — its target needs raising to ≥7.3.2 (andsharpto 0.35.4) when it comes back into play.🤖 Generated with Claude Code