fix: skip alias rendering when a step's if condition is false - #6744
Open
ausias-armesto wants to merge 1 commit into
Open
fix: skip alias rendering when a step's if condition is false#6744ausias-armesto wants to merge 1 commit into
ausias-armesto wants to merge 1 commit into
Conversation
Previously aliases were rendered unconditionally before the if-check, so an alias referencing another (skipped) step's result could raise a SyntaxError instead of the step being cleanly skipped. Aliases are now only rendered after we know the step will actually run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6743
Summary
Aliases were rendered unconditionally before the
ifcheck, so analias referencing another (skipped) step's result could raise a
SyntaxErrorinstead of the step being cleanly skipped. This movesalias rendering to after the
ifcheck, once we know the step willactually run.
Changes
keep/step/step.py: alias rendering moved from the top of_run_singleto after theifcheck passes.tests/test_steps.py: addstest_run_single_if_false_skips_alias_evaluationcovering thescenario above.
Test plan
pytest tests/test_steps.py -k alias