Show profile save behavior in browser tables - #222
Closed
IlyaasK wants to merge 2 commits into
Closed
Conversation
IlyaasK
marked this pull request as ready for review
August 10, 2026 19:18
sjmiller609
requested changes
Aug 10, 2026
sjmiller609
left a comment
Contributor
There was a problem hiding this comment.
thanks for putting this together. the browser tables intentionally show a curated subset of response fields, while the full response is available through --output json. the upstream request was for API visibility rather than human-readable CLI output.
if there isn't a concrete request to include this in the default CLI output, then I advise closing out this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
kernel browsers listtrueandfalsevalues while preserving omission when the API did not return the fieldWhy
kernel/kernel#3177 added
profile_save_changesto browser responses, andkernel-go-sdk v0.87.0generated the corresponding field. JSON output already included it automatically, but human-readable tables hid it, making it harder to identify sessions that can overwrite a profile.The CLI's current
mainbranch already depends onkernel-go-sdk v0.87.0, so no additional SDK dependency bump is needed in this PR.Behavior
Before, human-readable browser output showed the attached profile without indicating whether the session would save changes. After this PR, it displays Save Changes as
trueorfalse; list output uses-when the response omits the field.Verification
GOCACHE=/private/tmp/kernel-cli-profile-save-gocache make testgit diff --checkNote
Low Risk
CLI display-only changes with no request or persistence logic; low risk aside from table layout.
Overview
Human-readable browser output now surfaces
profile_save_changesfrom the API, which JSON output already exposed.kernel browsers listgains a Save Changes column. Create, get, and pool-acquire result tables show a Save Changes property when the field is present. A sharedformatProfileSaveChangeshelper printstrue/falseonly when the SDK marks the field valid; otherwise list rows use-and detail tables omit the row.Tests cover list output and
buildBrowserTableDataomission vs display behavior.Reviewed by Cursor Bugbot for commit e1230d6. Bugbot is set up for automated code reviews on this repo. Configure here.