feat(issue-details): per-tree incidents and first good checkout - #2050
Open
alanpeixinho wants to merge 1 commit into
Open
feat(issue-details): per-tree incidents and first good checkout#2050alanpeixinho wants to merge 1 commit into
alanpeixinho wants to merge 1 commit into
Conversation
- Add per-tree first/last seen and first good checkout on issue details
- Extend seen queries with group_by=tree and LATERAL first-good-checkout
- Wire per-tree data only on /api/issue/{id}; keep extras/listing unchanged
- Add IncidentsSection UI, types, locales, and OpenAPI schema updates
Closes kernelci#1957
Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Comment on lines
+297
to
+305
| AND C.git_repository_branch IS NOT NULL | ||
| ORDER BY | ||
| IC.issue_id, | ||
| C.tree_name, | ||
| C.git_repository_url, | ||
| C.git_repository_branch, | ||
| IC.issue_version {order_direction}, | ||
| IC._timestamp {order_direction} | ||
| ) | ||
| SELECT | ||
| IC.id, | ||
| IC.issue_id, | ||
| IC._timestamp AS first_seen, | ||
| IC.issue_version, | ||
| C.git_commit_hash, | ||
| C.git_repository_url, | ||
| C.git_repository_branch, | ||
| C.git_commit_name, | ||
| C.tree_name, | ||
| C.id as checkout_id | ||
| FROM | ||
| incidents IC | ||
| LEFT JOIN tests T ON IC.test_id = T.id | ||
| LEFT JOIN builds B ON ( | ||
| IC.build_id = B.id | ||
| OR T.build_id = B.id | ||
| ) | ||
| LEFT JOIN checkouts C ON B.checkout_id = C.id | ||
| JOIN target_incident TI ON IC.id = TI.id | ||
| """ | ||
| """ |
Member
There was a problem hiding this comment.
ranking by issue_version before _timestamp, so “last seen” is the highest/lowest version, not the latest failure. Is that right?
Contributor
Author
There was a problem hiding this comment.
I am keeping the behavior of the global "last seen" here, prioritizing latest version of the issue, and then using timestamp.
For what I see issue versioning is mostly used here as a way to make immutable data updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Per-tree incidents on the issue details page (
/issue/$issueId): first seen, last seen, and first good checkout (earliest later checkout on that tree with no incident for the issue).Backend adds
group_by=treeon seen queries and a single LATERAL first-good-checkout query. Wired only on/api/issue/{id}so extras/listing stay unchanged.Closes #1957
How to test