Skip to content

confd: set IITO startup/failure conditions (fixes status LEDs) #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjator wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −8
Open

confd: set IITO startup/failure conditions (fixes status LEDs) #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7c95cd
confd: set IITO startup/failure conditions (fixes status LEDs)
pjator Aug 17, 2026
0e1fbc3
Merge branch 'kernelkit:main' into nanopi-r2s-led
pjator Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...h64/friendlyarm-nanopi-r2s/rootfs/usr/share/product/friendlyarm,nanopi-r2s/etc/iitod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

"wan-up": { "path": "/run/led/wan-up" },

"startup": { "path": "/run/finit/cond/run/startup/success" },
"fail-safe": { "path": "/run/finit/cond/run/failure/success" },
"panic": { "path": "/run/finit/cond/run/failure/failure" }
"startup": { "path": "/run/finit/cond/usr/startup-config-ok" },
"fail-safe": { "path": "/run/finit/cond/usr/failure-config-ok" },
"panic": { "path": "/run/finit/cond/usr/failure-config-error" }
},
"udev": {
"power-a": { "subsystem": "power_supply" },
Expand Down
6 changes: 3 additions & 3 deletions board/common/rootfs/etc/iitod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"lan-err": { "path": "/run/led/lan-err" },
"lan-crit": { "path": "/run/led/lan-crit" },

"startup": { "path": "/run/finit/cond/run/startup/success" },
"fail-safe": { "path": "/run/finit/cond/run/failure/success" },
"panic": { "path": "/run/finit/cond/run/failure/failure" }
"startup": { "path": "/run/finit/cond/usr/startup-config-ok" },
"fail-safe": { "path": "/run/finit/cond/usr/failure-config-ok" },
"panic": { "path": "/run/finit/cond/usr/failure-config-error" }
},
"udev": {
"power-a": { "subsystem": "power_supply" },
Expand Down
27 changes: 25 additions & 2 deletions src/confd/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,23 @@
*/
#define SENTINEL_PATH "/run/confd.boot"

/*
* Set a finit condition in the usr/ namespace, e.g.
* "usr/startup-config-ok", used to signal IITO (and finit services) about
* the outcome of the bootstrap/startup sequence. Finit guarantees
* /run/finit/cond/usr exists (via its tmpfiles snippet), so no parent
* directories are created here.
*/
static void set_finit_cond(const char *cond)
{
char path[128];
snprintf(path, sizeof(path), "/run/finit/cond/usr/%s", cond);


if (symlink("/run/finit/cond/reconf", path) && errno != EEXIST)
WARN("Failed to set finit condition %s: %m", path);
}

/* Callback type names from sysrepo plugin API */
#define SRP_INIT_CB "sr_plugin_init_cb"
#define SRP_CLEANUP_CB "sr_plugin_cleanup_cb"
Expand Down Expand Up @@ -505,27 +522,32 @@ static void handle_startup_failure(sr_session_ctx_t *sess, const char *failure_p
int r;

ERROR("Failed loading startup-config, reverting to Fail Secure mode!");
set_finit_cond("startup-config-error");

/* Reset to factory-default */
r = sr_copy_config(sess, NULL, SR_DS_FACTORY_DEFAULT, timeout_ms);
if (r != SR_ERR_OK) {
ERROR("sr_copy_config(factory-default) failed: %s", sr_strerror(r));
/* Nuclear option: wipe everything */
banner_append("CRITICAL ERROR: Logins are disabled, no credentials available");
systemf("rm -f /etc/sysrepo/data/*startup* /etc/sysrepo/data/*running* /dev/shm/sr_*");
set_finit_cond("failure-config-error");
return;

@wkz wkz Aug 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troglobit: Should we not emit the CRITICAL ERROR: ... in this scenario as well? The system is still without any defined config in this case, no?

@troglobit troglobit Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The more feedback we can provide the user with in these cases the better. Possibly those cases could also be consolidated better than what I managed in my refactor.

}

/* Load failure-config on top */
if (fexist(failure_path)) {
if (load_config(conn, sess, failure_path, timeout_ms)) {
ERROR("Failed loading failure-config, aborting!");
ERROR("failed applying failure-config, aborting!");
banner_append("CRITICAL ERROR: Logins are disabled, no credentials available");
systemf("initctl -nbq runlevel 9");
set_finit_cond("failure-config-error");
return;
}
}

banner_append("ERROR: Corrupt startup-config, system has reverted to default login credentials");
set_finit_cond("failure-config-ok");
}

/*
Expand Down Expand Up @@ -587,6 +609,7 @@ static int bootstrap_config(sr_conn_ctx_t *conn, sr_session_ctx_t *sess,
if (r != SR_ERR_OK)
WARN("Failed to sync startup datastore: %s", sr_strerror(r));

set_finit_cond("startup-config-ok");
return 0;
}

Expand Down Expand Up @@ -841,7 +864,7 @@ int main(int argc, char **argv)
quiet_now();

/* Signal that bootstrap is complete (dbus, resolvconf depend on this) */
symlink("/run/finit/cond/reconf", "/run/finit/cond/usr/bootstrap");
set_finit_cond("bootstrap");

/*
* Write restart sentinel. From this point on, sysrepo and the system
Expand Down