Fix non userdata const reference overloads - #270
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a compile-time error in LuaBridge that occurred when using references or pointers to non-userdata types (like
int,double, orstd::string) withluabridge::overload<const T&>(...). The main change is making theisInstancemethod in severalStackOpSelectorspecializations a template, allowing correct instantiation and use with various types. New tests have been added to ensure these cases work as expected.Core Fixes to Type Handling:
isInstancea template method in all relevantStackOpSelectorspecializations for pointers and references to non-userdata types in bothDistribution/LuaBridge/LuaBridge.handSource/LuaBridge/detail/Stack.h, allowing proper compilation and usage with types likeint,double, andstd::string. [1] [2] [3] [4] [5] [6] [7] [8]Testing Improvements:
ReferenceAndPointerToNonUserdataTypestest inStackTests.cppto verify thatisInstanceworks for references and pointers to non-userdata types, and that explicit template arguments are handled correctly.OverloadTests.cppto ensure overloads with const reference parameters for non-userdata types and strings work without ambiguity or compile errors.