fix(audit): bootstrap template skips and pass-color signal matches - #53
Merged
Conversation
…tches Make malformed or unknown bootstrap metadata visible instead of silently dropping templates, treat onDemand/general as explicit vocabulary, and render successful PR signal matches as green so they no longer look degraded. Co-Authored-By: Warp <agent@warp.dev>
|
Warning Review limit reached
On-demand reviews are free for the next 27 days. After that, they cost $0.25 per reviewed file. Or wait 51 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 74 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (9)
Comment |
The SFE-1073 catalog fix now emits the security-patterns template into the sample-cli bootstrap golden, which copies the same documented example key already allowlisted in the source template. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SFE-1073 and SFE-1074 as a bounded one-off against current main (
ec4e279, same as the frozen Loupe evidence commit).SFE-1073 — bootstrap metadata validation
Malformed or unknown template metadata is no longer dropped silently. The loader names the file and missing/invalid field, treats
onDemandason-demandinstead ofalwaysApply, and givesgeneralexplicit match-all semantics. All 18 templates now load;performance-measure-before-optimizeis on-demand. Inventory/vocabulary tests and the bootstrap golden were updated deliberately.SFE-1074 — audit report status color
Successful PR rule-signal matches render as
🟢 signal matchinstead of yellow. Missing stays red; unknown stays unlabeled. Yellow remains the degraded/backlog color elsewhere in the report.Validation
bun test scripts/bootstrap-generate.test.ts scripts/audit-report-format.test.ts scripts/__tests__/golden.test.ts scripts/verify-self-audit-proof.test.tsbun run lint && bun run typecheck && bun test— 534 pass / 0 failConversation: https://app.warp.dev/conversation/9e0e7871-f0b3-46b9-9cc9-7405363f9b73
Co-Authored-By: Warp agent@warp.dev