feat: admin login - #92
Open
robsimmons wants to merge 7 commits into
Open
Conversation
robsimmons
force-pushed
the
push-yltnzrpvulrv
branch
2 times, most recently
from
August 21, 2026 19:12
2f6edad to
94f587f
Compare
robsimmons
force-pushed
the
push-yltnzrpvulrv
branch
2 times, most recently
from
August 21, 2026 19:29
82d4f90 to
b8844dd
Compare
robsimmons
force-pushed
the
push-yltnzrpvulrv
branch
from
August 22, 2026 17:11
59c6cfc to
cdbb520
Compare
reject password reset after setup is complete
robsimmons
force-pushed
the
push-yltnzrpvulrv
branch
from
August 22, 2026 17:44
cdbb520 to
f90c097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
adminanddevusers. Neither are created eagerly upon initialization; instead, /setup uses the signal ofinitAdminPasswordexisting to create the admin user, set the password to the user-provided value, and then delete initAdminPassword. Future visits to /setup will present the admin login option./admin becomes the intended way to do admin login when logged out.
The dev user is only created the first time someone clicks the
[DEV]button in development mode, and this PR removes the recently-added recurring check for deleting the dev user if it exists in production mode.Closes #88