fix: correct LEAN_EXPORT attribute order in ffi.cpp - #14888
Merged
Merged
Conversation
GCC ignores a visibility attribute placed before `extern "C"`, so these FFI getters were not exported from libleanshared under GCC. We confirmed that reordering to `extern "C" LEAN_EXPORT` fixes on GCC 11, 13 and 15.
joehendrix
marked this pull request as draft
August 21, 2026 17:41
joehendrix
marked this pull request as ready for review
August 21, 2026 17:43
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Kha
enabled auto-merge
August 25, 2026 12:41
Member
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes attribute/extern "C" ordering affecting builds with some versions of gcc.
Specifically, gcc ignores
LEAN_EXPORTvisibility attribute placed beforeextern "C", so these getters were not exported fromlibleanshared.This change was drafted with AI assistance. I confirmed that reordering to
extern "C" LEAN_EXPORTfixes on GCC 11, 13 and 15.