CI: also run the tests for pull requests - #152
Merged
ThomasWaldmann merged 1 commit intoSep 3, 2026
Merged
Conversation
The Test workflow only triggered on push, so pull requests never ran it - only the Codespell workflow showed up on a PR. Keeps the push trigger for all branches, so pushing a branch to a fork still runs the tests before a PR is opened. A concurrency group deduplicates the push and pull_request runs for the same branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.ymlonly triggerson: [push], so theTestworkflow never runs for apull request — the only check that shows up on a PR is Codespell (which does
have a
pull_request:trigger). Test results for a PR are currently onlyvisible if the contributor happens to look at the run on their own fork.
This adds a
pull_request:trigger for PRs targetingmain, and keeps theexisting unrestricted
push:trigger so pushing a branch to a fork still runsthe tests before a PR is opened. The added concurrency group keeps only the
most recent run per branch, so an in-repo PR branch (e.g. dependabot's) does
not run the same tests twice for the push and the pull_request event.
The
Testworkflow is currently failing onmain(unusedtyping.castimports, fixed in #151), so it will be red here until that lands.
🤖 Generated with Claude Code