Add bindings + tests for cubic Bézier, roots, and new predicates - #304
Merged
Conversation
Bump libigl to 477e15a (pinning Eigen 3.4.0 so the 64-bit-index bindings still compile) and add a new igl.cycodebase module plus bindings for the recently added cubic Bézier / root-finding functionality: - core: cubic, cubic_is_flat, cubic_monomial_bases, cubic_split, fit_cubic_bezier - cycodebase (new module): roots, box_cubic, point_cubic_squared_distance, point_spline_squared_distance, spline_eytzinger_aabb - predicates: cubic_winding_number, spline_winding_number, point_in_convex_hull; also update Orientation/incircle/insphere/ orient2d/orient3d for libigl moving Orientation to the igl:: namespace Adds 14 tests in tests/test_all.py with expectations cross-validated against independent numerical computation. Full suite: 90 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps libigl to
477e15aand adds Python bindings + tests for the recentlyadded cubic Bézier / root-finding functionality, including a new
igl.cycodebasemodule. Also bumps the package version to2.6.3.dev4.New bindings
core
cubic,cubic_is_flat,cubic_monomial_bases,cubic_split,fit_cubic_bezierigl.cycodebase(new module)roots,box_cubic,point_cubic_squared_distance,point_spline_squared_distance,spline_eytzinger_aabbpredicates
cubic_winding_number,spline_winding_number,point_in_convex_hullOrientation/incircle/insphere/orient2d/orient3dfor libiglmoving the
Orientationenum to the top-leveligl::namespaceBuild notes
LIBIGL_CYCODEBASEoption and wires the module through theexisting auto-glob
pyigl_include()mechanism.5.0.1, whose stricter
ScalarBinaryOpTraitsrejects the int64-vs-intcomparisons that the 64-bit-index bindings instantiate.
Testing
Adds 14 tests to
tests/test_all.py. Numeric expectations were cross-validatedagainst independent computation (numerical winding-number integration,
brute-force closest-point search). Full suite: 90 passed.
🤖 Generated with Claude Code