Add resolve_duplicated_faces binding; fix boundary_loop/vertex_components docs - #305
Merged
Merged
Conversation
…nents docs - Bind igl::resolve_duplicated_faces (core), returning (F2, J). Copies the input into a concrete matrix first since the implementation reuses the input's Derived type for internal plain objects (an Eigen::Ref won't default-construct). Docstring reflects actual Release behavior: the non-orientable case drops those faces rather than throwing (the rule-4 check is an IGL_ASSERT, compiled out in Release). Closes #277. - Fix the misleading comment on the boundary_loop wrapper (it returns the longest loop, not all loops). Related to #286. - Fix vertex_components docstring/comment: it takes a face list F and returns per-vertex component ids, not "an adjacency matrix ... and counts". Adds test_resolve_duplicated_faces covering the no-duplicate, cancel, keep-one, and non-orientable cases. Full suite: 91 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knocks out the easy items from the recent issue/PR triage.
New binding
igl.resolve_duplicated_faces(F1) -> (F2, J)(core). Closes resolve_duplicated_faces is missing in python package #277.implementation reuses the input's
Derivedtype for internal plain objects,so an
Eigen::Ref(whatnb::DRefproduces) fails to default-construct.non-orientable triangle (
|pos − neg| > 1) the C++ "throw" is anIGL_ASSERT, which is compiled out in Release, so those faces are simplydropped rather than raising.
test_resolve_duplicated_facescovers no-duplicate (identity), thecancel rule, the keep-one rule, and the non-orientable/drop case.
Doc fixes
boundary_loop.cpp: correct the copy-pasted comment on theboundary_loopwrapper — it returns only the longest loop, not all loops (related to boundary_loop_all isn't documented. #286;
boundary_loop_allalready exists for all loops).vertex_components.cpp: the docstring claimed it takes "an adjacency matrix …and counts", but the binding takes a face list
Fand returns only per-vertexcomponent ids. Fixed the comment, docstring, and
@param/@return.Testing
Built and ran the full suite locally: 91 passed (was 90).
🤖 Generated with Claude Code