Add BOLT 12 payer proof support - #845
Conversation
|
I've assigned @valentinewallace as a reviewer! |
vincenzopalazzo
changed the title
18e0c72 to
312b662
Compare
312b662 to
4e593b7
Compare
781d3ee to
0aaab83
Compare
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
26899ae to
a0641a2
Compare
| (3, quantity, option), | ||
| (4, secret, option), | ||
| (6, offer_id, required), | ||
| (8, bolt12_invoice, option), |
There was a problem hiding this comment.
As mentioned elsewhere, we probably don't want to do this, at least not before we can use #811
| scorer: Arc<Mutex<Scorer>>, | ||
| peer_store: Arc<PeerStore<Arc<Logger>>>, | ||
| payment_store: Arc<PaymentStore>, | ||
| payer_proof_context_store: Arc<PayerProofContextStore>, |
There was a problem hiding this comment.
No, I'd rather not add yet another store just for this. Can we store this in the payment metadata store post #811?
There was a problem hiding this comment.
yes OFC, I wanted to have a runnable version in a fork, but currently I am interesting in you giving some feedback on the payer proof API, if you think are good enough!
Thanks after ldk 0.3 I can wait for #811 and vibe code another integration :)
351cf83 to
82de0c7
Compare
vincenzopalazzo
changed the title
82de0c7 to
fbb3a7c
Compare
Add a `bolt12_invoice` field to `PaymentKind::Bolt12Offer` and `PaymentKind::Bolt12Refund`, and set it from `Event::PaymentSent` when a BOLT 12 payment succeeds. Besides being useful on its own, this gives us everything we need to build a payer proof for a past payment without keeping any additional state around: the invoice is persisted alongside the payment and thus survives restarts. This commit was written with AI assistance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Expose `Bolt12Payment::create_payer_proof`, which builds a BOLT 12 payer proof for a previously succeeded outbound BOLT 12 payment, with `PayerProofOptions` controlling which optional invoice fields are selectively disclosed. The proof is built purely from data we already persist in the payment store: the paid BOLT 12 invoice recorded on `PaymentKind::Bolt12Offer` / `PaymentKind::Bolt12Refund` and the payment preimage. That means payer proofs survive restarts and we don't need a second, node-lifetime-only store to keep the invoice context around. Payments that completed via a static invoice, i.e., async payments, don't support payer proofs and are rejected with `PayerProofUnavailable`. Also wires the new `PayerProof` type and the two new error variants through the UniFFI surface. This commit was written with AI assistance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fbb3a7c to
8ffb28b
Compare
3 participants
Summary
Adds support for building BOLT 12 payer proofs for previously succeeded outbound BOLT 12 payments:
PaymentKind::Bolt12Offer/PaymentKind::Bolt12Refund, set fromEvent::PaymentSentonce the payment succeeds.Bolt12Payment::create_payer_proof, which builds a payer proof from the persisted invoice and payment preimage.PayerProofOptionscontrols which optional invoice fields (offer description, issuer, amount, creation time, extra TLV types) are selectively disclosed, plus an optional proof note.PayerProoftype and error variants (PayerProofCreationFailed,PayerProofUnavailable,InvalidPayerProof) through the UniFFI surface.Since the proof is built purely from data persisted in the payment store, payer proofs survive restarts without any additional storage: no new KV namespace and no in-memory side store. Payments that completed via a static invoice (async payments) do not support payer proofs and are rejected with
PayerProofUnavailable.The payer proof primitives are already present in the
rust-lightningrevision we pin, so this PR does not patch LDK to a fork —Cargo.tomlis untouched.Verification
cargo fmt --all -- --checkcargo check --lib --tests --benches,cargo check --lib --features unifficargo clippy --lib -- -A warnings -D clippy::unwrap_used -A clippy::tabs_in_doc_commentscargo test --lib,cargo test --test upgrade_downgrade_testscargo test --test integration_tests_rust simple_bolt12_send_receive— extended to build a payer proof from the persisted payment and assert the payment hash, disclosed amount, proof note, and that undisclosed fields stay absentscripts/uniffi_bindgen_generate_python.sh)Disclosure
This PR was prepared with AI assistance (Claude Code).
🤖 Generated with Claude Code