feat: add bankAddress to USD funding payment instructions - #840
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript
|
Greptile Summaryฅ^•ﻌ•^ฅ This PR adds an optional, length-bounded
Confidence Score: 5/5The PR appears safe to merge, with the source schema, generated bundles, and documentation examples consistently updated. The new field is additive and optional, has appropriate validation bounds, and is represented consistently across the canonical schema and generated documentation artifacts.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/UsdAccountInfoBase.yaml | Adds the optional bankAddress property with clear documentation and string-length constraints to the canonical shared USD schema. |
| openapi.yaml | Correctly reflects the source-schema addition in the committed generated OpenAPI bundle. |
| mintlify/openapi.yaml | Remains synchronized with the root generated OpenAPI bundle. |
| mintlify/snippets/internal-accounts.mdx | Adds syntactically valid and realistic bankAddress values to both USD funding examples. |
Reviews (1): Last reviewed commit: "feat: add bankAddress to USD account inf..." | Re-trigger Greptile
Wire senders often need the beneficiary bank's postal address, so add an optional bankAddress field to PaymentUsdAccountInfo. It sits on the payment shape rather than the shared UsdAccountInfoBase so it does not appear as an accepted-then-ignored input on USD external accounts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
75fe165 to
2bd2e90
Compare
What this does
USD funding payment instructions tell someone how to send money into a Grid internal account. They carry an account number, a routing number, and the bank's name.
They do not carry the bank's address. Many originating banks will not send a wire until they have the beneficiary institution's postal address, so a platform has to look it up somewhere else and paste it in by hand.
This PR adds an optional
bankAddressfield toPaymentUsdAccountInfo.How it works
bankAddressis a single-line string, up to 255 characters. It is optional on every rail. It matters most on wires, where the originating bank asks for it.The field is additive. Nothing that reads USD funding instructions today has to change.
Where the field sits
It went on
PaymentUsdAccountInforather than on the sharedUsdAccountInfoBase.The base is also composed into USD external accounts. Those have no place to store a bank address, so adding it there would have advertised an input that the API accepts and then silently drops.
What else changed
The bundled
openapi.yamlandmintlify/openapi.yamlwere rebuilt withmake build, so the API reference picks the field up.make lintpasses.The two USD funding examples in the internal accounts docs snippet now show
bankAddressalongsidebankName.Related
The backend that fills this field in is lightsparkdev/webdev#32807.
🤖 Generated with Claude Code