Skip to content

Make the VASP url optional #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyav merged 1 commit into from
Aug 20, 2026
+3 −6
Merged

Make the VASP url optional #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions openapi/components/schemas/vasps/Vasp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
type: object
required:
- vaspName
Comment on lines 2 to 3

@greptile-apps greptile-apps Bot Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Empty URLs Remain Invalid

When the upstream directory returns url: "", removing url from required does not make that present value optional or valid; it still violates format: uri, causing strict response validators and generated clients that enforce URI formatting to reject real directory entries.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/vasps/Vasp.yaml
Line: 2-3

Comment:
**Empty URLs Remain Invalid**

When the upstream directory returns `url: ""`, removing `url` from `required` does not make that present value optional or valid; it still violates `format: uri`, causing strict response validators and generated clients that enforce URI formatting to reject real directory entries.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@shreyav shreyav Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just added this field its fine

@greptile-apps greptile-apps Bot Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough — making url optional is the right call if the upstream returns empty strings on most entries. My concern about format: uri rejecting "" still technically stands (an empty string isn't a valid URI), but if your validators/generated clients are lenient about format enforcement on optional fields, or you handle empty strings at the application layer, that's your call to make.

Happy to drop this.

- url
properties:
vaspName:
type: string
Expand All @@ -12,7 +11,7 @@ properties:
url:
type: string
format: uri
description: The VASP's website.
description: The VASP's website, when known.
example: https://www.kraken.com
description: >-
A Virtual Asset Service Provider (VASP) — an exchange or other custodial
Expand Down
Loading