fix(install): make binary install atomic - #2153
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
Use a temp directory under ~/.linkerd2 so mv to the install destination stays on the same filesystem. Fixes linkerd#90 Signed-off-by: amarkdotdev <amark@g.jct.ac.il> Signed-off-by: Aaron <amark@g.jct.ac.il>
amarkdotdev
force-pushed
the
fix/90-atomic-install
branch
from
September 4, 2026 08:00
85a6bb4 to
b8c0bff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$INSTALLROOT(default~/.linkerd2) somvto$INSTALLROOT/binstays on the same filesystem and remains atomic.linkerd2.*temp directories from interrupted installs before starting a new download.Fixes #90
Test plan
curl -fsSL https://run.linkerd.io/install | sh(or invoke the script locally) and confirm the CLI installs successfullylinkerd versionworks after install