Port to zgvariant - #552
Merged
Merged
Conversation
Collaborator
pam can be switched to use gvariant format |
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
The initial port left the client's D-Bus types still naming a bare `zvariant`, which no longer resolves now that the crate pulls `zgvariant` for the keyring file format and reaches D-Bus zvariant through `zbus`. Import the `zvariant` module from `zbus` so those references keep resolving. The pam module <-> daemon socket protocol is an internal wire format, not real D-Bus, so it now uses the GVariant encoding via `zgvariant` on both ends. This drops zvariant from the pam module entirely (it depends only on `zgvariant`) and keeps oo7 on a single serialization stack. Assisted-by: Claude Opus 4.8 (claude-opus-4-8)
Contributor
Author
Done. |
zeenix
marked this pull request as ready for review
August 18, 2026 12:12
Collaborator
|
lgtm, will merge once there is a release with the changes. |
Contributor
Author
It's already there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #550.
Moves oo7's GVariant usage off the (now-deprecated)
zvariant/gvariantfeature onto thestandalone
zgvariantcrate:clientuseszgvariantfor the keyring file format, and reaches the D-Bus zvariantthrough
zbus::zvariant(the same instance ashpd re-exports).uses the GVariant encoding via
zgvarianton both ends — the pam module and the daemon'spam_listener. This drops zvariant from the pam module entirely; it now depends only onzgvariant.Requires zvariant 5.15.0 / zvariant_utils 4.2.0 — the coexistence fix that lets zvariant's D-Bus
format and zgvariant's GVariant format share one build — now published, so the tree resolves
purely from crates.io.
Verified locally: the whole workspace builds, the pam and daemon
pam_listenerround-trip testspass (they exercise the socket wire format end-to-end), and clippy + rustfmt are clean.
Generated by Claude Opus 4.8 (claude-opus-4-8).