feat(company): add signedBy to the org CLA posture endpoint

[ahmedomosanya]

Adds signedBy to GET /v4/company/external/{companySFID}/cla-groups:
the CCLA signatory name already on the signature this handler loads
(sig.SignatoryName). Blank names are omitted; there is no CLA-manager
fallback. Additive and read-only.

Refs linuxfoundation/lfx-self-serve#2231

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6278c6ba-19ee-4f67-9835-42e3bb55e055

📥 Commits

Reviewing files that changed from the base of the PR and between ed712a3 and a3ba847.

📒 Files selected for processing (4)

• cla-backend-go/swagger/common/company-cla-group.yaml
• cla-backend-go/v2/company/service.go
• cla-backend-go/v2/company/service_test.go
• docs/M3_ORG_LENS_API.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The Company CLA Groups response now includes optional signedBy data from the CCLA signature. Empty signatory names remain omitted, with no CLA-manager fallback. Tests and Org Lens API documentation cover the new contract.

Changes

Company CLA signed-by response

Layer / File(s)	Summary
Signed-by contract and mapping cla-backend-go/swagger/common/company-cla-group.yaml, cla-backend-go/v2/company/service.go, cla-backend-go/v2/company/service_test.go, docs/M3_ORG_LENS_API.md	The service populates SignedBy from a non-empty SignatoryName. The schema, tests, and documentation define omission for empty values and no CLA-manager fallback.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a3ba8

The endpoint now additively returns the recorded CCLA signatory name when available and omits it otherwise. The documented response behavior is covered for populated and blank names, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding signedBy to the company CLA group endpoint.
Description check	✅ Passed	The description accurately explains the endpoint change, data source, blank-value behavior, and lack of CLA-manager fallback.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/GH-2231-signed-by

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Adds the CCLA signatory name as optional signedBy data in the organization CLA posture endpoint.

Changes:

• Adds signedBy to the Swagger contract and documentation.
• Maps non-blank SignatoryName values without manager fallback.
• Tests populated and omitted behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
docs/M3_ORG_LENS_API.md	Documents signedBy behavior.
cla-backend-go/v2/company/service.go	Populates signedBy from the signature.
cla-backend-go/v2/company/service_test.go	Tests mapping and omission behavior.
cla-backend-go/swagger/common/company-cla-group.yaml	Defines the optional response field.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[lukaszgryglicki]

/lgtm