feat: add GitHub security funnel table widget IN-1293 - #2168
Merged
Conversation
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a standalone GitHub security-coverage funnel widget for the Health Score Coverage report.
Changes:
- Adds the table widget with loading, empty, and footnote states.
- Adds Tinybird mapping, API, query, types, and tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
github-security-funnel.vue |
Renders the funnel table and states. |
github-security.query.ts |
Fetches and caches widget data. |
github-security.get.ts |
Exposes the report API endpoint. |
health-score-coverage-github-security.ts |
Fetches and maps Tinybird rows. |
health-score-coverage-github-security.test.ts |
Tests mapping and fetching. |
health-score-coverage-github-security.types.ts |
Defines widget data contracts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+73
to
+74
| A further {{ formatNumber(lfNonGithub) }} repositories sit on Gerrit, GitLab and elsewhere. There, these two | ||
| signals are absent by design rather than simply unscanned. |
|
|
||
| const lfNonGithub = computed(() => data.value?.lfNonGithub ?? 0); | ||
|
|
||
| const isEmpty = computed(() => !isLoading.value && stages.value.length === 0); |
This was referenced Sep 9, 2026
epipav
approved these changes
Sep 9, 2026
gaspergrom
merged commit Sep 9, 2026
b0103ba
into
release/IN-1276-health-score-coverage
6 checks passed
gaspergrom
added a commit
that referenced
this pull request
Sep 10, 2026
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standalone insights code for widget 08 of the Health Score Coverage report (IN-1293) — a table showing security-signal coverage across GitHub-hosted repos, split into a Linux Foundation and Other projects column, funnel-shaped by stage (Tracked in Insights → Health score published → Security category scored → Scanned by Scorecard).
github-security-funnel.vue— table widget, skeleton loading state, empty state, footnote with thelf_non_githubcounthealth-score-coverage-github-security.ts— data-fetcher + mapper (noscopeparam — the pipe returns both LF/Other columns in one call)health-score-coverage-github-security.test.ts— mapper unit tests, including a funnel-monotonicity assertiongithub-security.get.ts— API routegithub-security.query.ts— TanStack Query wrapperhealth-score-coverage-github-security.types.ts— standalone typesStandalone widget code only — NOT yet wired into the shared report view/service/types/data files. Wiring happens in a follow-up once prior widgets (#2164, #2165, #2166, #2167) merge into this release branch and it's IN-1293's turn in the sequential merge order. crowd.dev pipe
health_score_report_github_securityis already deployed to Tinybird production (crowd.dev PR #4582).Ground-truth discrepancy found vs. dispatch brief
The Jira ticket's prose lists the four table rows in this order: "Tracked in Insights, Scanned by Scorecard, Security category scored, Health score published." Taken literally, that order is not monotonically decreasing given the pipe's own validated production data (e.g. Other: tracked=11712, health_published=10758, security_scored=7756, scorecard_scanned=5901) — which conflicts with the ticket's own acceptance criterion "Each stage count is ≤ the stage above it in both columns."
Built to the funnel order stated in the pipe's DESCRIPTION block (
tracked >= health_published >= security_scored >= scorecard_scanned) and confirmed against live production data via the Tinybird MCP, treating the ticket's row-order sentence as a wording slip rather than the intended row order.Test plan
pnpm lint:fix— no errors (pre-existing warnings elsewhere, untouched)pnpm tsc-check— cleanpnpm test --run— 254/254 passing, including the new mapper testsrelease/IN-1276-health-score-coverage-