fix: health score report LF/non-LF color convention IN-1304 - #2205
Merged
Merged
Conversation
Applies the report-wide Linux-Foundation-vs-other-projects color convention (brand blue for LF, violet for non-LF) to the "Signal availability inside and outside the Linux Foundation" widget. It previously colored the Linux Foundation series per-category (matching the neighboring signal-scores widget's category colors) with the "Other" series always gray, which read as inconsistent for a widget that is specifically an LF-vs-other comparison rather than a category comparison. No chart type change. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes LF-vs-other colors in the signal availability widget.
Changes:
- Uses brand blue for LF and violet for other projects.
- Updates legend colors and removes category-color indicators.
- Simplifies chart configuration.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+126
to
+128
| // Report-wide LF-vs-non-LF color convention: Linux Foundation projects always blue, other tracked | ||
| // projects always purple, consistent across every category group (this widget IS an LF-vs-other | ||
| // comparison, unlike widget 03's Top-20%-vs-median comparison, which keeps its own category colors). |
gaspergrom
changed the base branch from
release/IN-1304-health-score-report-feedback
to
main
September 15, 2026 13:08
epipav
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the report-wide Linux-Foundation-vs-other-projects color convention (brand blue for LF, violet for non-LF, consistently) to the "Signal availability inside and outside the Linux Foundation" widget (
signal-availability-lf.vue). It previously colored the Linux Foundation bars per-category — matching the unrelated signal-scores widget's category-color scheme — with the "Other" series always neutral gray, which read as inconsistent for a widget whose entire point is an LF-vs-other comparison, not a category comparison. No chart type change for this widget.Known/accepted limitation
This widget still shows a binary Linux-Foundation-vs-Other comparison rather than a full distribution, because the underlying Tinybird pipe only returns one aggregate percentage per scope. A true distribution chart would need a backend/pipe change, out of scope for this frontend-only pass.
Test plan
pnpm tsc-check— passespnpm lint:fix— 0 errors (pre-existing unrelated warnings only)pnpm test— all assertions passDeploy order
N/A — frontend-only change, no backend/pipe dependency.
Migration checklist
N/A — no database changes.
Notes
Independent of the other three PRs in this set (copy/structure #2203, chart conversions #2204) — targets
release/IN-1304-health-score-report-feedbackdirectly since it only touches this one widget's colors and has no shared-file overlap with the others.release/IN-1304-health-score-report-feedback-