Include new Rust token source - #36
Open
MaxHeimbrock wants to merge 2 commits into
Open
Conversation
MaxHeimbrock
force-pushed
the
max/include-token-source
branch
from
July 22, 2026 14:20
104e7e0 to
86cc4b7
Compare
MaxHeimbrock
force-pushed
the
max/include-token-source
branch
from
August 3, 2026 14:54
82dc6df to
c00f555
Compare
MaxHeimbrock
marked this pull request as ready for review
August 13, 2026 09:19
Sandbox id works, but no other fields possible yet Cargo changes for local dev Also have fields for all fetch options Some cleanup after CI complained Adapt to fetch options builder Using factory pattern Make cargo toml use real deps Needed for rebase Adapt to stream options builder API StreamTextOptions and StreamByteOptions no longer implement Default in the local rust-sdks checkout; construct them via new_with_topic and with_destination_identities instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Adapted to newest version Adjusted to basic factory constructor Working version matches Format check
MaxHeimbrock
force-pushed
the
max/include-token-source
branch
from
August 24, 2026 08:25
344e61f to
9c3d871
Compare
1egoman
approved these changes
Aug 24, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me, called out a few nitpicks / small suggestions I think could make it a little more elegant!
Comment on lines
+55
to
+65
| Auth::TokenSource { | ||
| token_server_id, | ||
| options, | ||
| } => { | ||
| let token_source = development_token_server(token_server_id); | ||
| let response = token_source | ||
| .fetch(options) | ||
| .await | ||
| .map_err(|e| e.to_string())?; | ||
| Ok((response.server_url, response.participant_token)) | ||
| } |
Contributor
There was a problem hiding this comment.
nitpick: Maybe make it Auth::DevelopmentTokenServer or similar to line up with the token source type?
Comment on lines
+116
to
+125
| token_server_id: String, | ||
| // Token-source fetch options (`ts_` to keep them apart from the API-key | ||
| // tab's identity/room). Empty means "omit, let the server default". | ||
| ts_room_name: String, | ||
| ts_participant_name: String, | ||
| ts_participant_identity: String, | ||
| ts_participant_metadata: String, | ||
| ts_agent_name: String, | ||
| ts_agent_metadata: String, | ||
| ts_agent_deployment: String, |
Contributor
There was a problem hiding this comment.
suggestion: It might be good to refactor all these token source metadata fields into a nested struct rather than adding the ts_ prefix.
| method: AuthMethod::default(), | ||
| url: env_or("LIVEKIT_URL", "ws://localhost:7880"), | ||
| token: env_or("LIVEKIT_TOKEN", ""), | ||
| token_server_id: "token-server-id".to_string(), |
Contributor
There was a problem hiding this comment.
question: Is this the right Default for this field? Or should it be an empty string?
Comment on lines
+211
to
+227
| let mut options = TokenSourceFetchOptions::new(); | ||
| if let Some(v) = opt(&self.ts_room_name) { | ||
| options = options.with_room_name(v); | ||
| } | ||
| if let Some(v) = opt(&self.ts_participant_name) { | ||
| options = options.with_participant_name(v); | ||
| } | ||
| if let Some(v) = opt(&self.ts_participant_identity) { | ||
| options = options.with_participant_identity(v); | ||
| } | ||
| if let Some(v) = opt(&self.ts_participant_metadata) { | ||
| options = options.with_participant_metadata(v); | ||
| } | ||
| if let Some(v) = opt(&self.ts_agent_name) { | ||
| options = options.with_agent_name(v); | ||
| } | ||
| if let Some(v) = opt(&self.ts_agent_metadata) { |
Contributor
There was a problem hiding this comment.
(note that if you namespaced all this ts_ stuff under a new struct type, then you could encapsulate all this code in a impl From<NewStruct> for TokenSourceFetchOptions which might be a little cleaner)
Co-authored-by: Ryan Gaus <rsg1egoman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tab to the connection options: