Fix start local audio - #1045
Conversation
This comment has been minimized.
This comment has been minimized.
|
@hiroshihorie when disposing the local track, the system says the audio is still being captured. I feel like |
|
I've been using this branch for a while. iOS only. |
|
Closing this one, it has been superseded by #1115 (shipped in 2.9.0). That PR moved audio processing setup into the capture start path, so track.start() now starts the native ADM through the SDK's own channel even when the track is not published. The visualizer use case this PR was for works on 2.9.0+ with a plain track.start(), no manual ADM calls needed. @bdlukaa the two issues you reported here are also addressed by the new path: failures now surface as typed AudioProcessingException with a reason instead of the opaque adm error string, and tracks clean up capture when startup fails. If you still hit either on 2.9.0+ please open an issue. The one part of this PR that did not land anywhere is the public Hardware.startLocalRecording/stopLocalRecording API. Will open a separate PR with @experimental annotations if a concrete use case for manual ADM control comes up. |
Ensure native ADM is started when track.start() is called so audio frames get generated (for visualizer)
Also expose manual adm start/stop methods.