fix(auth): require exp claim when verifying access tokens - #1706
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Verify() parsed with WithValidMethods/WithIssuer/WithLeeway but not WithExpirationRequired, so a token carrying no exp claim at all passed validation and never expired. First-party SDKs always set exp, but any hand-rolled or third-party minter that forgets it silently mints a permanent credential.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
APIKeyTokenVerifier.Verifyparses withWithValidMethods/WithIssuer/WithLeewaybut notWithExpirationRequired. Under golang-jwt v5, a token carrying noexpclaim at all passes validation and never expires.First-party SDKs always set
exp(the Go SDK unconditionally defaults it inToJWT), so this doesn't affect well-behaved minters — but any hand-rolled or third-party minter that forgetsexpsilently mints a permanent credential, and the server accepts it without complaint.Fix
Add
jwt.WithExpirationRequired()to the parse options. One line; tokens with a validexpare unaffected.Tests
Added
token without exp is rejectedtoTestVerifier, using a hand-rolledjwt.MapClaimstoken (the Go SDK always setsexp, so the case has to be built directly).go test ./auth/passes.Made with Cursor
Made with Cursor