Skip to content

🐛 Open binary AIGER files in binary mode - #709

Open
marcelwa wants to merge 1 commit into
lsils:masterfrom
marcelwa:fix-upstream-aiger-binary-mode
Open

marcelwa wants to merge 1 commit into
lsils:masterfrom
marcelwa:fix-upstream-aiger-binary-mode

Conversation

@marcelwa

@marcelwa marcelwa commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Filename-based binary AIGER writes can be corrupted on Windows because the output stream was opened in text mode. It opens the file in binary mode and adds a byte-exact regression whose encoded 0x0A byte would otherwise be translated to CRLF; the focused and full test suites pass on Windows.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.06%. Comparing base (0886ebf) to head (63b32d1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files         190      190           
  Lines       29515    29519    +4     
=======================================
+ Hits        24812    24816    +4     
  Misses       4703     4703           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant