Skip to content

SP-3366: incorporate feedback from Slack on 301 4 - #194

Merged
MelissaGraham merged 2 commits into
tickets/SP-3327from
tickets/SP-3366
Aug 12, 2026
Merged

SP-3366: incorporate feedback from Slack on 301 4#194
MelissaGraham merged 2 commits into
tickets/SP-3327from
tickets/SP-3366

Conversation

@MelissaGraham

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rhiannonlynne

Copy link
Copy Markdown
Member

df = pd.merge(tap_results_df, temp_df, on='visit', how='inner')

should probably be how = 'left' for the described purpose (to match all of the tap_results_df values).
Of course, in this case, there had best be visit dimension records for all of the tap_results_df values, so it works the same.

@rhiannonlynne rhiannonlynne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Melissa!

@MelissaGraham
MelissaGraham merged commit 9031eec into tickets/SP-3327 Aug 12, 2026
2 checks passed
@MelissaGraham
MelissaGraham deleted the tickets/SP-3366 branch August 12, 2026 02:59
MelissaGraham added a commit that referenced this pull request Aug 12, 2026
* feedback from Slack

* incorporate LJ feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants