docs(config): correct the BigQuery test-environment step - #342
Merged
Conversation
An empty or unset serviceAccountKeyJson leaves the SDK's credentials option unset, so the connection uses application default credentials. Testing means logging in and leaving the variable alone, not filling it from the ADC file. Use jq -c for the production key, and restore the serviceAccountKey note that lost its opening sentence. Signed-off-by: Lloyd Tabb <lloyd.tabb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #340, which merged before this correction landed.
An empty or unset
serviceAccountKeyJsonleaves the SDK'scredentialsoption unset, so the connection uses application default credentials. Testing therefore means logging in and leaving the variable alone — not filling it from the ADC file, which is anauthorized_usercredential and gets rejected as not a service account key.exportofapplication_default_credentials.json;gcloud auth login --update-adcis the whole step.jq -cfor the production key, so the value is a single line that survives.envfiles and CI secret fields.serviceAccountKeynote, which a condensing pass in docs(config): document the BigQuery server setup #340 clipped into a dangling fragment.The lead sentence about application default credentials is folded into step 2 rather than stated twice. The
authClientsection from #341 is untouched.Verification
npm run buildcompiles clean.Generated by Claude Code