Match retail Classic character-screen and initial login flow - #481
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 84 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
MadMaxMangos
force-pushed
the
fix/retail-character-screen-addon-order
branch
from
August 21, 2026 15:10
203d6bc to
2c000b3
Compare
MadMaxMangos
marked this pull request as ready for review
August 21, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SMSG_CHAR_ENUMto avoid redundant login verification while preserving a one-shot admission fallbackSTARTdelayed until world presentation andGOon the following eligible tickdocs/artifacts are includedIntentional scope
Far-worldport and transport-seam ACK handling retain their legacy packet path. Unifying that destination flow is a separate follow-up and this change does not alter its deck-coordinate or movement semantics.
Verification
cmake --build E:\Mangos\WIP\Zero\Testing\server_build --config RelWithDebInfo --target mangosd mangos_tests --parallel 8ctest --test-dir E:\Mangos\WIP\Zero\Testing\server_build -C RelWithDebInfo --output-on-failureThis change is