Skip to content

Match retail Classic character-screen and initial login flow - #481

Merged
MadMaxMangos merged 14 commits into
masterfrom
fix/retail-character-screen-addon-order
Aug 21, 2026
Merged

Match retail Classic character-screen and initial login flow#481
MadMaxMangos merged 14 commits into
masterfrom
fix/retail-character-screen-addon-order

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • match the observed Classic character-screen order by deferring addon metadata until character enumeration and starting Warden after the completed character list
  • use the map advertised by SMSG_CHAR_ENUM to avoid redundant login verification while preserving a one-shot admission fallback
  • move social lists into the pre-world preamble and add an explicit initial-world entry lifecycle
  • consolidate self, inventory, visibility, vessel, and crew creates into one initial object update with the Classic transport header state
  • reproduce the retail spell-836 login-effect order, with START delayed until world presentation and GO on the following eligible tick
  • keep protocol and ownership rationale inline in the behavioral commits; no standalone docs/ artifacts are included

Intentional scope

Far-worldport and transport-seam ACK handling retain their legacy packet path. Unifying that destination flow is a separate follow-up and this change does not alter its deck-coordinate or movement semantics.

Verification

  • cmake --build E:\Mangos\WIP\Zero\Testing\server_build --config RelWithDebInfo --target mangosd mangos_tests --parallel 8
  • ctest --test-dir E:\Mangos\WIP\Zero\Testing\server_build -C RelWithDebInfo --output-on-failure
  • 16/16 configured tests passed
  • repeated Classic 1.12.1 login/relogin testing confirmed smooth world presentation and visible delayed login effect

This change is Reviewable

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 84 complexity · 0 duplication

Metric Results
Complexity 84
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos
MadMaxMangos force-pushed the fix/retail-character-screen-addon-order branch from 203d6bc to 2c000b3 Compare August 21, 2026 15:10
@MadMaxMangos
MadMaxMangos marked this pull request as ready for review August 21, 2026 15:11
@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos
MadMaxMangos merged commit 402c570 into master Aug 21, 2026
8 checks passed
@MadMaxMangos
MadMaxMangos deleted the fix/retail-character-screen-addon-order branch August 21, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants