Feature/panoramax by ofr1tz · Pull Request #236 · mapswipe/mapswipe-backend

ofr1tz · 2026-02-23T16:30:40Z

Depends on

Changes

This enables the MapSwipe backend to handle View Streets projects with different image providers (currently Mapillary and Panoramax).

Adds image provider to the View Streets project specifics
Adds logic to download and process Panoramax metadata
Maps Panoramax metadata attribute names on the respective Mapillary attribute names for filtering
Changes max length of task ID to accommodate Panoramax image IDs as task IDs

This PR doesn't introduce any:

This PR contains valid:

tests
permission checks (tests here too)
translations

codecov · 2026-02-24T12:47:12Z

Codecov Report

❌ Patch coverage is 90.13158% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.45%. Comparing base (2fdd94a) to head (2341f6d).

Files with missing lines	Patch %	Lines
utils/geo/street_image_provider/models.py	69.23%	5 Missing and 3 partials ⚠️
project_types/street/api_calls.py	87.09%	2 Missing and 2 partials ⚠️
project_types/street/project.py	82.35%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    87.39%   87.45%   +0.05%     
===========================================
  Files          212      213       +1     
  Lines        12900    13006     +106     
  Branches      1093     1109      +16     
===========================================
+ Hits         11274    11374     +100     
- Misses        1226     1231       +5     
- Partials       400      401       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

susilnem · 2026-03-10T08:16:27Z

Shouldn't this be in street/project.py?

This is consistent with raster_tile_server and vector_tile_server also in utils/geo/

tnagorra · 2026-04-15T04:53:07Z

+    elif provider.name in (StreetImageProviderNameEnum.PANORAMAX, StreetImageProviderNameEnum.PANORAMAX_CUSTOM):
+        base = (provider.url or Config.PANORAMAX_API_LINK).rstrip("/")
+        url = f"{base}/api/map/{z}/{x}/{y}.mvt"


What is the different between PANORMAX and PANORAMAX_CUSTOM?
Do we need both of these?

Also, the code above indicates that user can override MAPILLARY url

The difference is:

PANORAMAX uses the default public Metacatalog API endpoint with access to images of all federated Panoramax instances.

PANORAMAX_CUSTOM allows users to specify a custom Panoramax API URL and thereby uses images from unfederated instances, or filter for images from a specific Panoramax instance.

Both use the same API format (/api/map/{z}/{x}/{y}.mvt) and return the same data structure, but PANORAMAX_CUSTOM is validated to require a URL.

The requirement to add an explicit PANORAMAX_CUSTOM came from review of the changes in Manager Dashboard: mapswipe/manager-dashboard#74 (review)

I agree that the user should not be able to override the MAPILLARY url, as the Pydantic validator in StreetImageProvider already enforces. I pushed a commit that clearly indicates that we always call the Mapillary API at Config.MAPILLARY_API_LINK.

Can we document this somewhere in the code? Just a simple NOTE will be good.

If a provider.url is defined for PANORAMAX_CUSTOM and not defined for PANORAMAX then we should have different if/else so that the behavior is more explicit.

tnagorra · 2026-07-17T02:03:03Z

+def backfill_image_provider(apps, schema_editor):
+    Project = apps.get_model('project', 'Project')
+
+    for project in Project._default_manager.all():


We should use a filter instead of fetching all projects.

tnagorra · 2026-07-17T02:03:20Z

+            project.project_type_specifics['imageProvider'] = {
+                'name': 'MAPILLARY'
+            }
+        project.save(update_fields=['project_type_specifics'])


We should do a bulk save during migration

tnagorra · 2026-07-17T02:03:49Z

+    for project in Project._default_manager.all():
+        if project.project_type != 7:  # STREET type
+            continue
+
+        if project.project_type_specifics is None:


We should filter instead of using continue.

tnagorra · 2026-07-17T02:04:18Z

+                    f"Migrating isPano to panoOnly for project {project.id} ({project.name})"
+                )
+                filters['panoOnly'] = filters.pop('isPano')
+                project.save(update_fields=['project_type_specifics'])


We should do a bulk save.
Bulk save also return the no. of updates made.

Add logic from mapswipe/python-mapswipe-workers@dev...panoramax and refactor StreetImageProvider. This introduces a type change of View Streets project tasks taskId that requires migration and changes in Firebase.

…oramax ids

…nsure correct sorting, sampling threshhold input in m instead km

…pano

Co-authored-by: Sushil Tiwari <susiltiwari750@gmail.com>

…ke name required

…ider is mapillary, correct type hint

… mandatory image provider

…tespace in migration

…shold to meters > Migrations 0013/0014 used camelCase keys but project_type_specifics is stored snake_case. Also add a migration to convert legacy sampling_threshold values from km (float) to m (int).

ofr1tz mentioned this pull request Feb 24, 2026

Feature/panoramax mapswipe/manager-dashboard#74

Open

9 tasks

ofr1tz marked this pull request as ready for review February 24, 2026 17:42

frozenhelium requested a review from susilnem March 6, 2026 08:09

susilnem requested changes Mar 11, 2026

View reviewed changes

ofr1tz force-pushed the feature/panoramax branch from 71352ae to f15f817 Compare March 19, 2026 15:50

ofr1tz requested a review from susilnem March 23, 2026 16:06

ofr1tz force-pushed the feature/panoramax branch 2 times, most recently from a2dad0a to f15f817 Compare March 23, 2026 16:53

tnagorra requested changes Apr 2, 2026

View reviewed changes

Comment thread apps/project/models.py Outdated

Comment thread project_types/street/api_calls.py Outdated

Comment thread schema.graphql

Comment thread schema.graphql Outdated

Comment thread schema.graphql Outdated

Comment thread project_types/street/project.py Outdated

tnagorra requested changes Apr 15, 2026

View reviewed changes

ofr1tz force-pushed the feature/panoramax branch from d4cb5bf to 5a5553c Compare April 29, 2026 08:44

tnagorra reviewed Jul 17, 2026

View reviewed changes

ofr1tz added 14 commits September 3, 2026 16:14

feature(street): add image provider in schema

f737555

feat(street): add panoramax as image provider

753fd51

Add logic from mapswipe/python-mapswipe-workers@dev...panoramax and refactor StreetImageProvider. This introduces a type change of View Streets project tasks taskId that requires migration and changes in Firebase.

feat(street): update schema for image provider selection

de7b43d

feat(street): extend firebase_id char length to 36 to accommodate pan…

fcd277d

…oramax ids

feat(street): use safe image provider api url

56d05d3

feat(street): add image provider to firebase project type specifics

7756d6b

feat(street): add image provider to firebase tutorial

d592854

feat(street): Correctly convert Mapillary and Panoramax timestamps, e…

592f24b

…nsure correct sorting, sampling threshhold input in m instead km

fix(street): format and typechecks

f28be23

feat(street): fix tests

9592c76

feat(street): improve cov

9210670

feat(streets): format

ef09421

feat(street): fix test

0daf169

feat(street): add panoramax custom to enum, use pano_only instead is_…

e63470e

…pano

ofr1tz and others added 14 commits September 3, 2026 16:44

fix(street): formatting

38e68e1

fix(street): ruff errors

3d8fa0b

fix(street): adjust tests

484ca93

feat(street): remove url from provider if Mapillary

0c07cba

Update utils/spatial_sampling.py

52f8f12

Co-authored-by: Sushil Tiwari <susiltiwari750@gmail.com>

refactor(street): move tile level logic to StreetImageProvider and ma…

03fd21d

…ke name required

feat(street): update graphql schema

795825d

fix(street): Use assert_never, cast firebase task id to int when prov…

fe9edd7

…ider is mapillary, correct type hint

fix(street): update e2e test, firebase submodule pointer

4d1cd8c

feat(street): remove Mapillary from names

dc38989

feat(street): mandatory image provider

2790b80

fix(street): format image provider backfill migration, adapt tests to…

5cabadb

… mandatory image provider

feat(street): migrate isPano to panoOnly

8c8b218

fix(street): always call Mapillary API at MAPILLARY_API_LINK, fix whi…

1652e8d

…tespace in migration

ofr1tz force-pushed the feature/panoramax branch from 5a5553c to 1652e8d Compare September 3, 2026 14:46

ofr1tz added 6 commits September 3, 2026 16:56

fix: merge migrations

dabb573

feat(streets): update submodule pointer for updated fixtures

2341f6d

fix(street): fix snake_case keys in migrations, convert sampling_thre…

a100c31

…shold to meters > Migrations 0013/0014 used camelCase keys but project_type_specifics is stored snake_case. Also add a migration to convert legacy sampling_threshold values from km (float) to m (int).

feat(street): filter Street projects in queryset for migrations

a23c672

fix(street): fix image_provider default name casing in migration

244ffe5

feat(street): use bulk update on migrations

aff9070

Conversation

ofr1tz commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

This PR doesn't introduce any:

This PR contains valid:

Uh oh!

codecov Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tnagorra Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ofr1tz commented Feb 23, 2026 •

edited

Loading

codecov Bot commented Feb 24, 2026 •

edited

Loading

tnagorra Jul 17, 2026 •

edited

Loading