Cache files that cannot save space with WOF compression - #25
Draft
marcmy wants to merge 1 commit into
Draft
Conversation
marcmy
changed the base branch from
agent/harden-background-compressor-stalls
to
master
August 18, 2026 10:05
marcmy
force-pushed
the
agent/cache-not-beneficial-files
branch
from
August 18, 2026 10:07
d5e77e0 to
121b3b9
Compare
marcmy
changed the base branch from
master
to
agent/harden-background-compressor-stalls
August 18, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WofSetFileDataLocationreturnsERROR_COMPRESSION_NOT_BENEFICIALcompression-not-beneficial.jsonWhy
Windows documents
ERROR_COMPRESSION_NOT_BENEFICIALas the WOF result used when compression was attempted but saved no disk space. Retrying the same unchanged file with the same algorithm on every run only wastes time.Behavior
The first non-beneficial attempt still appears as a failed file for that run and is written to the cache. Future normal compression work-list builds omit that unchanged file for the same algorithm. If the file changes, or the user selects another WOF algorithm, CompactGUI tries it again.
Explicit file lists are intentionally not filtered by this cache so restore/undo operations are never blocked by a cached compression result.
Scope
This PR is stacked on #23 because both modify
CompactGUI.Core/Compactor.cs. Relative to #23 it changes only:CompactGUI.Core/Compactor.csCompactGUI.Core/CompressionNotBeneficialCache.csAfter #23 merges, this PR can be retargeted to
masterwithout carrying unrelated changes.Validation
masterto exercise the repository's PR build workflowRuntime checks