Skip to content

Fix compressor skip-list filtering - #28

Merged
marcmy merged 1 commit into
agent/fix-manual-resume-statefrom
agent/fix-skip-filtering
Aug 20, 2026
Merged

Fix compressor skip-list filtering#28
marcmy merged 1 commit into
agent/fix-manual-resume-statefrom
agent/fix-skip-filtering

Conversation

@marcmy

@marcmy marcmy commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • fix the compressor work-list filter so entries explicitly marked as non-compressible are actually excluded
  • handle both extension entries (for example .mp4) and exact file paths in the same skip set
  • make skip matching case-insensitive, consistent with Windows path semantics

Root cause

The current predicate combines extension and exact-path checks with this condition:

((fl.FileInfo != null && !excludedFileExtensions.Contains(fl.FileInfo.Extension))
    || excludedFileExtensions.Contains(fl.FileName))

That final || excludedFileExtensions.Contains(fl.FileName) is inverted: an exact file path in the exclusion list makes the predicate true instead of excluding the file. The set is also case-sensitive.

This matters specifically for the previously determined per-file poor-compression list: CompactGUI passes those entries to the compactor as exact full paths, so the old predicate could make the very file that was supposed to be skipped eligible for compression.

Expected behavior

A file is eligible only when:

  • it is not already using the selected compression mode
  • it is not excluded by a resume checkpoint
  • it is larger than the filesystem cluster size
  • its extension is not in the configured non-compressible extension list
  • its exact path is not in the folder/wiki poor-compression skip list

Validation

Runtime checks

  1. Enable the built-in poorly-compressed file-type skip option and verify known excluded extensions do not appear in the compression work list.
  2. Enable the user/wiki poor-compression skip option and verify exact file paths identified as poor candidates do not appear in the work list.
  3. Repeat with path/extension casing differences and verify exclusions remain case-insensitive.
  4. Disable the relevant skip option and verify those files can become eligible again.

@marcmy
marcmy marked this pull request as ready for review August 20, 2026 14:54
@marcmy
marcmy force-pushed the agent/fix-skip-filtering branch from 4ccbd2c to 222142b Compare August 20, 2026 15:09
@marcmy
marcmy merged commit f90b697 into master Aug 20, 2026
9 checks passed
@marcmy
marcmy deleted the agent/fix-skip-filtering branch August 20, 2026 15:14
@marcmy
marcmy restored the agent/fix-skip-filtering branch August 20, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant