Fix compressor skip-list filtering - #28
Merged
Merged
Conversation
This was referenced Aug 18, 2026
marcmy
marked this pull request as ready for review
August 20, 2026 14:54
marcmy
force-pushed
the
agent/fix-skip-filtering
branch
from
August 20, 2026 15:09
4ccbd2c to
222142b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mp4) and exact file paths in the same skip setRoot cause
The current predicate combines extension and exact-path checks with this condition:
That final
|| excludedFileExtensions.Contains(fl.FileName)is inverted: an exact file path in the exclusion list makes the predicate true instead of excluding the file. The set is also case-sensitive.This matters specifically for the previously determined per-file poor-compression list: CompactGUI passes those entries to the compactor as exact full paths, so the old predicate could make the very file that was supposed to be skipped eligible for compression.
Expected behavior
A file is eligible only when:
Validation
Runtime checks