Version constants track netcode 1.4.4, and the check covers all four - #24
Merged
Conversation
Upstream cut 1.4.4 on 2026-08-26 (strict floating-point builds:
-ffp-contract=off replaces -ffast-math on every target). That is a C build
discipline with no wire or API implication for this port, so the sync is the
version markers only.
VersionPatch was 0, and was already wrong before this release: the 1.4.x line
should have carried 3, then 4. It drifted undetected because the version-sync
job compared VersionFull alone, so it reported green while three of the four
constants it exists to police went unread.
So the job now compares all four against NETCODE_VERSION_*, keeping the
existing empty-extraction guards per constant and reporting every mismatch in
one run rather than stopping at the first.
These are not the protocol version on the wire; versionInfo ("NETCODE 1.02\0")
is unchanged and never changes.
Verified: all four extract cleanly from both files and match; restoring
VersionPatch = 0 makes the widened job fail with a named error, which is the
state the old job called green. go build and go test pass.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream cut netcode 1.4.4 on 2026-08-26 — strict floating-point builds,
-ffp-contract=offreplacing-ffast-mathon every target. That is a C build discipline with no wire or API implication for this port, so what is owed here is the version markers and nothing else.While making that sync:
VersionPatchwas0, and was already wrong before this release — the 1.4.x line should have carried3, then4. It drifted undetected because theversion-syncjob comparedVersionFullalone, so the job reported green while three of the four constants it exists to police went unread. The job's own comment already said to bump all four; it just never checked them.So this bumps the constants to
1.4.4 / 1 / 4 / 4and widens the job to compare all four againstNETCODE_VERSION_*, keeping the existing empty-extraction guards per constant and reporting every mismatch in one run rather than stopping at the first.These are not the protocol version on the wire.
versionInfo("NETCODE 1.02\0") is untouched and never changes.Verified
VersionPatch = 0makes the widened job fail with::error::VersionPATCH is 0 but mas-bandwidth/netcode is 4— the exact state the old job called green.go build ./...andgo test ./...pass.Found while draining a wake backlog: this check was the red on #23, whose own diff is a README support line and could not have caused it.