Follow the redesigned site selector dropdown in the UI test - #276
Merged
Merged
Conversation
tzi
force-pushed
the
design-system-site-selector-dropdown
branch
from
September 2, 2026 11:50
9223438 to
ed24414
Compare
…_release] The option list is no longer cut off by the form it sits in, so both shots now show the whole report list, site 2's goals among them. Synced from the core build that carries the change.
Naming the option list in the capture made the image's height depend on whether the browser had re-laid it out before the harness measured, so the same code produced a 1843px or a 1965px image from one run to the next. The page wrap alone is stable, and the reports themselves are asserted against the DOM.
tzi
force-pushed
the
design-system-site-selector-dropdown
branch
from
September 8, 2026 09:10
ed24414 to
a738d21
Compare
The site selector dropdown no longer carries the legacy `dropdown` class; it is now a `.piwikSelector__dropdown` wrapper around `.mtm-dropdownPanel`. Without this the jQuery selector matches nothing, the click never happens and the alert-condition screenshot captures a stale site.
tzi
force-pushed
the
design-system-site-selector-dropdown
branch
from
September 11, 2026 09:31
a738d21 to
163b073
Compare
tzi
marked this pull request as ready for review
September 14, 2026 02:13
snake14
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Points the site selector clicks in the UI test at the redesigned dropdown panel.
Impact
None visible to users: this repository only changes a UI test selector, which follows the site selector redesign in core.
Step by step tests
With the core branch pinned
design-system-site-selector-dropdown), which pins this branch asplugins/CustomAlerts.ddev matomo:console tests:run-ui --plugin=CustomAlerts.👁️ All specs pass, including the ones that switch site through the selector.
Why the selector changed
tests/UI/CustomAlerts_spec.js.👁️ Both site selector clicks now target
.siteSelector .piwikSelector__dropdown liinstead of.siteSelector .dropdown li.👁️ The core PR drops the
dropdownclass from the panel, so the old selector matches no list item and the click silently does nothing.Against core 6.x-dev
6.x-devinstead.👁️ Expect the site-switching specs to fail: the new selector only exists with the core PR.
Checklist