[SM6.10] LinAlg Validation: MatrixOuterProduct - #8808
Open
Ashley Coleman (V-FEXrt) wants to merge 2 commits into
Open
[SM6.10] LinAlg Validation: MatrixOuterProduct#8808Ashley Coleman (V-FEXrt) wants to merge 2 commits into
Ashley Coleman (V-FEXrt) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements Shader Model 6.10 validation rules for MatrixOuterProduct.
Changes:
- Validates matrix scope, use, dimensions, and element types.
- Adds validation diagnostics and component-type helpers.
- Adds DXIL validation tests and corrects nominal code-generation expectations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
utils/hct/hctdb.py |
Adds and generalizes validation rules. |
tools/clang/test/LitDXILValidation/LinAlgMatrix/linalgmatrix-outerproduct.ll |
Tests valid and invalid outer products. |
tools/clang/test/CodeGenDXIL/hlsl/linalg/builtins/matrixouterproduct/nominal.hlsl |
Updates nominal matrix attributes. |
lib/DxilValidation/DxilValidationUtils.h |
Declares component-type helpers. |
lib/DxilValidation/DxilValidationUtils.cpp |
Implements component-type helpers. |
lib/DxilValidation/DxilValidation.cpp |
Implements outer-product validation. |
docs/DXIL.rst |
Documents the new diagnostics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8508
Implements MatrixOuterProduct validation rules