[NFC] Generalise the LinAlg matrix arithmetic test helpers - #8810
Merged
Jack Elliott (JoeCitizen) merged 1 commit intoAug 20, 2026
Merged
Conversation
Make the Wave-scoped matrix arithmetic helpers scope-neutral so they can be reused by future ThreadGroup coverage. There is no functional change and the 59-test set is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b Assisted-by: GitHub Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Generalizes LinAlg matrix arithmetic test helpers for reuse across matrix scopes without changing existing Wave test behavior.
Changes:
- Renames Wave-specific helper types and functions.
- Parameterizes matrix scope and thread count.
- Preserves Wave-specific capability selection in a wrapper.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Damyan Pepper (damyanp)
approved these changes
Aug 19, 2026
Finn Plummer (inbelic)
approved these changes
Aug 19, 2026
Joshua Batista (bob80905)
approved these changes
Aug 19, 2026
Jack Elliott (JoeCitizen)
enabled auto-merge (squash)
August 20, 2026 00:53
Jack Elliott (JoeCitizen)
merged commit Aug 20, 2026
18867b7
into
microsoft:main
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LinAlg matrix arithmetic test helpers were written for Wave-scoped cases and carry
Wavein their names, but nothing in them is actually Wave-specific. This renames them to scope-neutral equivalents so ThreadGroup-scoped coverage can reuse them rather than duplicating the code.