Fix unexpected results in unit tests - #386
Open
Chanel (chanel-y) wants to merge 7 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| sink b[0] | ||
| sink b[1] # $ hasValueFlow=11.1 | ||
| sink b[2] | ||
| sink b[2] # $ hasValueFlow=11.2 |
Collaborator
There was a problem hiding this comment.
I'm confused by this one. Why do we need to add this one while the upstream version of this file doesn't have it? Are we running with an older version of Ruby's dataflow library?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All test annotation fixes, except for powershell
Powershell's unexpected alert was a false positive, since it was flagging parameters from a powershell pipeline, which shouldn't be included in LocalSource.qll, so the change there was excluding PipelineByPropertyNameParameter and PipelineParameter from that classs