Skip to content

Fix network isolation issues in CI pipeline - #494

Merged
Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/fix-network-isolation-issues
Aug 14, 2026
Merged

Fix network isolation issues in CI pipeline#494
Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/fix-network-isolation-issues

Conversation

@vmoroz

Copy link
Copy Markdown
Member

Summary

Fix the office/ISS test jobs under network isolation by keeping npm install off registry.npmjs.org and pointing it to the approved Azure DevOps feed instead.

What changed

  • Added feed-aware npm config in .ado/publish.yml for the shared test job variables:
    • NPM_CONFIG_USERCONFIG=$(Build.SourcesDirectory)/.npmrc
    • NPM_CONFIG_CACHE=$(Agent.TempDirectory)/.npmCache
  • Kept the test-project package closure deterministic by pinning the fixture dependency versions in the test projects.
  • Updated global.json to the current .NET servicing SDK so CI stays on the supported baseline.

Why

The test suite shells out to npm install for the JS/TS fixture projects. Without the feed override, npm falls back to registry.npmjs.org, which is blocked by the office/ISS network-isolation policy. This caused the isolated test jobs to fail even though the build/package jobs were fine.

Validation

  • CI is green with the office/ISS network-isolation rules in place.
  • The test jobs no longer hit the public npm registry.
  • The fix is limited to build infrastructure and test setup; there is no product/runtime change in the shipped library.

Copilot AI balanced review requested due to automatic review settings August 14, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes fixture npm installs through the approved Azure DevOps feed for network-isolated CI.

Changes:

  • Configures npm registry and cache paths for test jobs.
  • Pins fixture dependencies for deterministic installation.
  • Updates the .NET SDK to 10.0.303.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.ado/publish.yml Configures isolated test-job npm access.
global.json Updates the servicing SDK.
test/TestCases/projects/ts-esm-module/package.json Pins fixture dependencies.
test/TestCases/projects/ts-esm-dynamic/package.json Pins fixture dependencies.
test/TestCases/projects/ts-cjs-module/package.json Pins fixture dependencies.
test/TestCases/projects/ts-cjs-dynamic/package.json Pins fixture dependencies.
test/TestCases/projects/js-esm-module/package.json Pins fixture dependencies.
test/TestCases/projects/js-esm-dynamic/package.json Pins fixture dependencies.
test/TestCases/projects/js-cjs-module/package.json Pins fixture dependencies.
test/TestCases/projects/js-cjs-dynamic/package.json Pins fixture dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@vmoroz
Vladimir Morozov (vmoroz) merged commit 3417c9a into microsoft:main Aug 14, 2026
17 checks passed
@vmoroz
Vladimir Morozov (vmoroz) deleted the PR/fix-network-isolation-issues branch August 14, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants