Fix network isolation issues in CI pipeline - #494
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoAug 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Routes fixture npm installs through the approved Azure DevOps feed for network-isolated CI.
Changes:
- Configures npm registry and cache paths for test jobs.
- Pins fixture dependencies for deterministic installation.
- Updates the .NET SDK to 10.0.303.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.ado/publish.yml |
Configures isolated test-job npm access. |
global.json |
Updates the servicing SDK. |
test/TestCases/projects/ts-esm-module/package.json |
Pins fixture dependencies. |
test/TestCases/projects/ts-esm-dynamic/package.json |
Pins fixture dependencies. |
test/TestCases/projects/ts-cjs-module/package.json |
Pins fixture dependencies. |
test/TestCases/projects/ts-cjs-dynamic/package.json |
Pins fixture dependencies. |
test/TestCases/projects/js-esm-module/package.json |
Pins fixture dependencies. |
test/TestCases/projects/js-esm-dynamic/package.json |
Pins fixture dependencies. |
test/TestCases/projects/js-cjs-module/package.json |
Pins fixture dependencies. |
test/TestCases/projects/js-cjs-dynamic/package.json |
Pins fixture dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jason Ginchereau (jasongin)
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
office/ISStest jobs under network isolation by keepingnpm installoffregistry.npmjs.organd pointing it to the approved Azure DevOps feed instead.What changed
.ado/publish.ymlfor the shared test job variables:NPM_CONFIG_USERCONFIG=$(Build.SourcesDirectory)/.npmrcNPM_CONFIG_CACHE=$(Agent.TempDirectory)/.npmCacheglobal.jsonto the current .NET servicing SDK so CI stays on the supported baseline.Why
The test suite shells out to
npm installfor the JS/TS fixture projects. Without the feed override, npm falls back toregistry.npmjs.org, which is blocked by theoffice/ISSnetwork-isolation policy. This caused the isolated test jobs to fail even though the build/package jobs were fine.Validation
office/ISSnetwork-isolation rules in place.