Skip to content

Add automatic text direction detection + Right to Left Capbilities - #3448

Open
Karlee Wong (KarleeWong) wants to merge 9 commits into
microsoft:masterfrom
KarleeWong:karleewong/rtlrooster
Open

Add automatic text direction detection + Right to Left Capbilities#3448
Karlee Wong (KarleeWong) wants to merge 9 commits into
microsoft:masterfrom
KarleeWong:karleewong/rtlrooster

Conversation

@KarleeWong

@KarleeWong Karlee Wong (KarleeWong) commented Aug 24, 2026

Copy link
Copy Markdown

Summary

Adds opt-in automatic text direction detection based on the first strong directional character in the active block.

Changes

  • Update setModelDirection to:
    • Combine paragraph text segments.
    • Ignore leading numbers, whitespace, and punctuation.
    • Determine direction from the first letter, LTR mark, or RTL mark.
    • Default to LTR when no strong directional character exists.
  • Export setModelDirection for model-level use.
  • Add AutoDirectionPlugin.
    • Handles regular insertText input.
    • Handles compositionEnd for IME keyboards.
    • Updates direction without invoking the public API or focusing the editor.
  • Export the plugin from roosterjs-content-model-plugins.
  • Register the plugin in the RoosterJS demo.
  • Add model and plugin unit tests.

Behavior

  • שלום English uses RTL.
  • Hello שלום uses LTR.
  • 123 مرحبا uses RTL because leading numbers and punctuation are ignored.
  • Content without a strong directional character defaults to LTR.
  • Existing editors are unchanged unless AutoDirectionPlugin is registered.

Video

Recording.2026-08-25.115834.mp4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@KarleeWong Karlee Wong (KarleeWong) changed the title Right to Left Rooster Add automatic text direction detection + Right to Left Capbilities Aug 25, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Karlee Wong (@KarleeWong) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

onPluginEvent(event: PluginEvent) {
if (
this.editor &&
(event.eventType === 'compositionEnd' ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be part of AutoFormatPlugin? we just need to create an option called auto direction to enable and disabled this feature.

(event.eventType === 'compositionEnd' ||
(event.eventType === 'input' && event.rawEvent.inputType === 'insertText'))
) {
this.editor.formatContentModel(model => setModelDirection(model, 'auto'), {

@juliaroldi Julia Roldi (juliaroldi) Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the setDirection function, can we modify setDirection to get the changes you did in setModelDirection. What do you think?

(event.eventType === 'compositionEnd' ||
(event.eventType === 'input' && event.rawEvent.inputType === 'insertText'))
) {
this.editor.formatContentModel(model => setModelDirection(model, 'auto'), {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be careful when we call formatContentModel. Try only call it when we are sure we want to modify the model. So better check the input before we call this API. Because >99.9% cases we don't need to change the direction.

return 'ltr';
}
}
import { findListItemsInSameThread } from '../list/findListItemsInSameThread';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the EndOfLine character is different so it is hard to tell what is changed.

block.style.direction;

if (expectedDirection && currentDirection !== expectedDirection) {
editor.formatContentModel(model => setModelDirection(model, 'auto'), {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use the setDirection api from roosterjs-content-model-api package.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 6bc76b6. AutoFormatPlugin now calls setDirection(editor, 'auto') after the cheap DOM direction check confirms a change is needed.

return;
}

const selection = editor.getDOMSelection();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the selection on line 299, why not reuse it here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 6bc76b6. The regular insertText path now passes the existing selection.range into handleAutoDirection, so it only calls getDOMSelection once.

selection.type === 'range' &&
selection.range.collapsed
) {
this.handleAutoDirection(editor, rawEvent.data);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle auto direct and other keyboard events together?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 6bc76b6. Auto direction is now handled in the same input-data switch as the existing keyboard features; compositionEnd remains a separate event path for IME input.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants