Support partial shortcut overrides in ShortcutPlugin - #3450
Closed
Vi Nguyen (vinguyen12) wants to merge 1 commit into
Closed
Support partial shortcut overrides in ShortcutPlugin#3450Vi Nguyen (vinguyen12) wants to merge 1 commit into
Vi Nguyen (vinguyen12) wants to merge 1 commit into
Conversation
Vi Nguyen (vinguyen12)
requested review from
Bryan Valverde U (BryanValverdeU),
Jiuqing Song (JiuqingSong),
flyingbee2012,
Ian Elizondo (ianeli1) and
Julia Roldi (juliaroldi)
and removed request for
Jiuqing Song (JiuqingSong)
August 24, 2026 20:53
|
Contributor
Author
|
Shortcuts are exported so we can build entire shortcut list in consumer apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds partial override support to
ShortcutPlugin, allowing consumers to customize selected built-in shortcut keys without replacing the complete command list.An override changes only the selected command's shortcut key. Its callback, environment, command identity, matching order, and all unaffected default shortcuts remain unchanged.
Backward compatibility
• new ShortcutPlugin() continues to use all built-in shortcuts.
• new ShortcutPlugin(undefined) continues to use all built-in shortcuts.
• Passing a ShortcutCommand[] continues to replace the complete built-in command list.
• Existing shortcut matching behavior and precedence are preserved.
API changes
Exports:
• ShortcutPluginOptions
• DefaultShortcutCommandName