Add C# Spector scenario coverage - #11693
Merged
JoshLove-msft merged 2 commits intoAug 17, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fce3f59e-5e13-4881-96b8-bc2cc41dcf44
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fce3f59e-5e13-4881-96b8-bc2cc41dcf44
JoshLove-msft
requested review from
Jorge Rangel (jorgerangel-msft),
Jose Arriaga Maldonado (joseharriaga),
Jesse Squire (jsquire) and
m-nash
as code owners
August 15, 2026 03:55
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the C# Spector test suite to cover additional HTTP parameter scenarios (nested @bodyRoot bodies and $-prefixed query parameter names) and re-enables the JSONL send streaming scenario now that the upstream gap has been addressed.
Changes:
- Add the
http/parameters/body-rootSpector project to the C# Spector test project and introduce a new test covering nested@bodyRootparameters. - Add a new query-parameter test case covering dollar-sign (
$) query parameter names. - Re-enable the JSONL
Sendscenario test by removing the prior ignore.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/http-client-csharp/generator/TestProjects/Spector.Tests/TestProjects.Spector.Tests.csproj | Adds the Parameters.BodyRoot project reference so the new body-root tests compile/run. |
| packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/Streaming/Jsonl/JsonlTests.cs | Removes the ignore to re-enable the JSONL send scenario. |
| packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/Parameters/Query/QueryTests.cs | Adds coverage for $-style query parameter naming via the DollarSign scenario. |
| packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/Parameters/BodyRoot/BodyRootTests.cs | New test validating nested @bodyRoot request body parameter handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
commit: |
Contributor
|
No changes needing a change description found. |
JoshLove-msft
enabled auto-merge
August 17, 2026 17:55
Jorge Rangel (jorgerangel-msft)
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bodyRootparameters@encode(string)boolean serialization in C# emitter ignores @encode(string) on boolean model properties #11691Validation
npm run build(with NuGet audit disabled after nuget.org audit endpoint failures)pwsh eng/scripts/Test-Spector.ps1 -filter "http/parameters/body-root"pwsh eng/scripts/Test-Spector.ps1 -filter "http/parameters/query"pwsh eng/scripts/Test-Spector.ps1 -filter "http/streaming/jsonl"dotnet format whitespace generator/TestProjects/Spector.Tests/TestProjects.Spector.Tests.csproj --include generator/TestProjects/Spector.Tests/Http/Parameters/BodyRoot/BodyRootTests.cs generator/TestProjects/Spector.Tests/Http/Parameters/Query/QueryTests.cs generator/TestProjects/Spector.Tests/Http/Streaming/Jsonl/JsonlTests.cs --verify-no-changes --no-restorenpm run cop