Skip to content

Perform the rescan when adding a standalone address #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erubboli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Perform the rescan when adding a standalone address #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ The format is loosely based on [Keep a Changelog](https://keepachangelog.com/en/

## [Unreleased]

### Fixed
- Wallet:
- Fixed an issue where `standalone-add-watch-only-address`, `standalone-add-private-key-from-hex` and
`standalone-add-multisig` (and the corresponding RPC methods) would reset the wallet to genesis but never
perform the announced rescan; the rescan is now done before the command returns. Previously, in `wallet-cli`
non-interactive mode the process would exit before the background rescan could run, leaving the wallet
stuck at genesis so that every subsequent wallet open had to rescan the whole blockchain.

## [1.4.0] - 2026-07-09

### Added
Expand Down
9 changes: 6 additions & 3 deletions wallet/wallet-rpc-lib/src/rpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,9 @@ where
.await?
.add_standalone_address(pkh, label);

if !no_rescan {
if res.is_ok() && !no_rescan {
w.reset_wallet_to_genesis()?;
w.sync_once().await?;
}

res
Expand Down Expand Up @@ -396,8 +397,9 @@ where
.await?
.add_standalone_private_key(private_key, label);

if !no_rescan {
if res.is_ok() && !no_rescan {
w.reset_wallet_to_genesis()?;
w.sync_once().await?;
}

res
Expand Down Expand Up @@ -455,8 +457,9 @@ where
.await?
.add_standalone_multisig(challenge, label);

if !no_rescan {
if res.is_ok() && !no_rescan {
w.reset_wallet_to_genesis()?;
w.sync_once().await?;
}

res
Expand Down
Loading