feat(app): locale migration L2 — default-locale App cutover - #173
Merged
Conversation
Add app/(default-locale)/ at unprefixed URLs (/ , /privacy, /daily, /playground, /profile). Remove duplicate Pages marketing routes (Next.js forbids App + Pages on the same path). Drop next.config i18n so app/[lang] serves /de, /fr, etc. Extend proxy locale header for unprefixed paths. Includes L2 e2e smoke, preview-smoke /daily path, and design doc updates.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mkayander
marked this pull request as ready for review
August 22, 2026 20:44
Vercel preview uses a fresh session; the consent overlay covers the footer and ambiguous Privacy policy links caused the pilot footer navigation test to flake.
Metadata API omits other tags with empty string values. Render the literal <meta name="darkreader-lock" /> in app/layout.tsx to match _document.tsx; add unit and e2e smoke so it stays on the L2 default-locale routes.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 22, 2026
# [1.385.0](v1.384.0...v1.385.0) (2026-08-22) ### Features * **app:** locale migration L2 — default-locale App cutover ([#173](#173)) ([7d3da8d](7d3da8d))
|
🎉 This PR is included in version 1.385.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locale migration L2: cut default-locale public traffic to App Router and remove duplicate Pages marketing routes.
Approach (learned from L2 spike)
next.configrewrites/→/enloop with Pagesi18n(which 308-strips/en). Next.js also forbids App + Pages on the same path at build time. L2 therefore:app/(default-locale)/— unprefixed/,/privacy,/daily,/playground,/profile(shared views + indexable metadata).index,privacy,daily,playground,profile(L3 partial, required for build).i18nfromnext.config.mjs— required soapp/[lang]serves/de,/fr, … after Pages removal.proxy.ts— locale header on unprefixed marketing paths.CI / review fixes
<meta name="darkreader-lock" />inapp/layout.tsx(Metadataotherskipped empty values); e2e smoke on/.Testing
pnpm lint— passpnpm test— pass (incl.appDocumentMetadataunit test)pnpm build— passpnpm test:e2e— 16/16 pass locallyNext (L3b)
Retire
/internal-marketing/*pilot (301 → public App routes).