feat(app): locale migration L3b — retire internal-marketing pilot - #174
Merged
Conversation
Add 308 redirects from /internal-marketing/* and /en/* to public App routes, delete the noindex pilot tree, and update proxy, playgroundRoute, e2e, and preview-smoke accordingly.
Use playgroundBasePathForLocale for /en/playground parsing, scope app-locale-routes e2e to non-default locales, assert 308 redirect status, and update stale pilot TODO wording.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mkayander
marked this pull request as ready for review
August 23, 2026 18:35
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 23, 2026
# [1.386.0](v1.385.0...v1.386.0) (2026-08-23) ### Features * **app:** locale migration L3b — retire internal-marketing pilot ([#174](#174)) ([3adfd15](3adfd15))
|
🎉 This PR is included in version 1.386.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires the
/internal-marketing/*App Router pilot now that L1/L2 public routes are live.next.config.mjs:/internal-marketing/en→//internal-marketing/en/:path*→/:path*/internal-marketing/:locale→/:locale/internal-marketing/:locale/:path*→/:locale/:path*/en→/and/en/:path*→/:path*(SEO dedupe)src/app/internal-marketing/(9 files)proxy.ts,playgroundRoute.ts, e2e,previewSmoke.ts, docsReview follow-ups (commit
a4d81fba)parsePlaygroundPathname:/en/playgroundnow normalizes to/playgroundviaplaygroundBasePathForLocaleapp-locale-routes.spec.ts: scoped to non-default locales (/de/*); en cases covered by L2/L3bmaxRedirects: 0Instant-Navigations-TODO.mdTest plan
pnpm test— 457 unit tests passpnpm lint— ESLint + tsc cleanpnpm build— production build succeedspnpm test:e2e— 17/17 pass (includes 308 redirect assertion)pnpm preview-smoke— legacy URLs redirect then 200Walkthrough
internal-marketing/en redirects to home
internal-marketing/de/daily redirects to /de/daily
Next steps (post-merge)
cacheComponents/ Instant Nav flags (blocked on rootheaders())(default-locale)/vs[lang]/page modulesTo show artifacts inline, enable in settings.