fix: normalize const/single-value enums to IRModelConst - #531
Merged
Conversation
The JSON Schema `const` keyword (OpenAPI 3.1) was parsed away silently, widening literal types to their base type and breaking discriminated unions. Introduce an IRModelConst abstraction used for both `const` and single-value `enum` (which default to closed), so enum extensibility never applies to a constant. Update type/schema builders and the discriminator check, and add a const-based discriminated union to the todo-lists integration spec. closes #529
Delegate number enum literals to the abstract literal(), use z.coerce.number() in the coercion preprocess, and route boolean enum values through booleanLiteral so they stay permissive and consistent with boolean const.
mnahkies
marked this pull request as ready for review
August 15, 2026 10:00
mnahkies
enabled auto-merge (squash)
August 15, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON Schema
constkeyword (OpenAPI 3.1) was parsed away silently, widening literal types to their base type and breaking discriminated unions. Introduce an IRModelConst abstraction used for bothconstand single-valueenum(which default to closed), so enum extensibility never applies to a constant.Update type/schema builders and the discriminator check, and add a const-based discriminated union to the todo-lists integration spec.
Also addresses a few discrepancies where literals would've failed at runtime if used in a query string setting. Now coerced to
number/booleancorrectly.closes #529