fix(dispatcher): advance mint counter past caller-supplied IDs (#3126) - #3237
Open
elang2 wants to merge 1 commit into
Open
fix(dispatcher): advance mint counter past caller-supplied IDs (#3126)#3237elang2 wants to merge 1 commit into
elang2 wants to merge 1 commit into
Conversation
…ontextprotocol#3126) When a caller supplies an integer request ID via CallOptions["request_id"], advance the monotonic mint counter past it so future auto-minted IDs never collide with a previously-used supplied ID. This satisfies the JSON-RPC spec requirement that request IDs MUST NOT be reused within the same session. Applied to both JSONRPCDispatcher and DirectDispatcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_next_idtomax(_next_id, supplied_id)in bothJsonRpcDispatcherandDirectDispatcherTest plan
pair_factoryparametrization)Fixes #3126