fix(mgr): сортировка секций на странице товара по sort_order - #620
Open
Ibochkarev wants to merge 1 commit into
Open
fix(mgr): сортировка секций на странице товара по sort_order#620Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Group ProductDataFields sections into a sort_order-ordered array so Utilities ranking is not lost to JS id-keyed object enumeration (#611).
AgelxNash
pushed a commit
to AgelxNash/MiniShop3
that referenced
this pull request
Sep 6, 2026
16 tasks
AgelxNash
pushed a commit
to AgelxNash/MiniShop3
that referenced
this pull request
Sep 6, 2026
… MODX Conflict resolution: keep array-based fieldsBySections (merged modx-pro#620/modx-pro#611), port fieldHtmlId labels + isCheckboxXtype/normalizeCheckboxValue helpers on top.
AgelxNash
pushed a commit
to AgelxNash/MiniShop3
that referenced
this pull request
Sep 6, 2026
Conflict resolution: PR 640 supersedes merged modx-pro#621 rework (same author, same intent) — took PR side for 36 files; manually preserved modx-pro#631 useConfirm grids, modx-pro#623 datefield dialog styles, modx-pro#643 gallery bits, modx-pro#605 order entry; ProductData sections rebuilt on groupProductDataSections (keeps modx-pro#611/modx-pro#620 sort_order) under PR 640 Panel layout.
|
Этот PR включён в тестовую интеграционную сборку всех открытых PR MiniShop3: AgelxNash/MiniShop3, ветка Сборка нужна, чтобы проверить совместимость взаимозависимых серий PR до их мержа — при последовательном слиянии они конфликтуют друг с другом. Это не ревью и не конкурирующий PR: авторство сохранено (1 PR = 1 коммит с исходным автором), ветка пересобирается по мере обновления PR. Как вошёл в сборку: Слился чисто. (Его |
16 tasks
|
Желаю скорейшего ревью и мержа! Красивый PR 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
На странице товара секции полей игнорировали порядок из Утилиты → Поля товара и шли по возрастанию ID секции.
getPageFieldsотдаётsectionsобъектом с числовыми ключами. Группировка в plain object +v-forв JS перечисляет integer-like keys по id, а не поsort_order.Исправление:
groupProductDataSectionsсобирает секции в массив и сортирует поsort_order(tie-break по id).ProductDataFieldsрендерит этот массив.Тип изменений
Связанные Issues
Closes #611
Как это было протестировано?
vueManager/src/utils/groupProductDataSections.test.js(4/4)project.test, товар id=2021: до фикса… → Дополнительно → Валюта(id-order); после —… → Валюта (sort 25) → Дополнительно (sort 40)Локальный CI-гейт (без полной установки MODX/MySQL), PHP lint + vueManager jobs из
.github/workflows/ci.yml:npm testVitest по util)Конфигурация тестирования:
fix/issue-611-product-section-sort-orderЧеклист
Дополнительные заметки
Routing issue-to-pr: plan=
cursor-grok-4.6-high-fast, make=composer-2.5-fast, review=gpt-5.6-sol-medium+ thermo=cursor-grok-4.6-high-fast. Reviews: APPROVE.