Conversation
chutten
approved these changes
Sep 11, 2026
| test-swift: | ||
| runs-on: macos-latest | ||
| needs: [decide-runs] | ||
| if: needs.decide-runs.outputs.rust-changed == 'true' || needs.decide-runs.outputs.swift-changed == 'true' |
Contributor
There was a problem hiding this comment.
Does this mean an end to /run-ios?
Also, running all swift tests on all rust changes? Is that a change?
Member
Author
There was a problem hiding this comment.
- Yes! We run iOS builds by default now
- Yes! We did that whole /run-ios part and not running by default because of cost. macOS time was costly on CircleCI and we were asked to reduce it. Until someone tells me that about GitHub Actions we will just default to running it.
Comment on lines
+360
to
+376
| - &swift-build-environment | ||
| name: Setup build environment | ||
| run: | | ||
| set -x | ||
| rustup target add aarch64-apple-ios aarch64-apple-ios-sim x86_64-apple-ios | ||
|
|
||
| # For some reason everything works fine if we use the host clang, | ||
| # not the Xcode-bundled clang. | ||
| echo '[target.aarch64-apple-darwin]' >> ~/.cargo/config.toml | ||
| echo 'linker = "/usr/bin/cc"' >> ~/.cargo/config.toml | ||
|
|
||
| # List available devices -- allows us to see what's there | ||
| DEVICES=$(xcrun xctrace list devices 2>&1) | ||
| echo "$DEVICES" | ||
| # Pick a device and start it | ||
| UUID=$(echo "$DEVICES" | grep --max-count=1 'iPhone 17 Simulator (26' | awk -F'[()]' '{print $4}') | ||
| xcrun simctl boot "$UUID" |
Contributor
There was a problem hiding this comment.
I can rubber-stamp this, but if you want a real review you may need to tap someone who understands mac/ios/swift.
Member
Author
There was a problem hiding this comment.
It's copied from what we do on CircleCI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.